Bug 211529 – [ContentObservation] Shutterstock search bar is not activated on the first tap

• Status: RESOLVED
• Resolution: FIXED
• Component: Layout and Rendering

[zalan]

<rdar://problem/58843932>

[zalan]

Created attachment 398663 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 398663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398663&action=review

> Source/WebKit/ChangeLog:12
> +        Itâs very difficult to eliminate such false positives since all we see is that some (actionable)content is going away while some (actionable)content is being created.

(actionable)content

> Source/WebCore/page/Quirks.cpp:808
> +    return isFirstSyntheticClickOnPage && (equalLettersIgnoringASCIICase(host, "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com"));

Surprised we don't have a helper for (equalLettersIgnoringASCIICase(host, "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com")) yet

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3301
> +    m_hasHandledSyntheticClick = false;

Maybe add a comment saying that this is only used for a quirk, otherwise our future selves will forget.

[zalan]

Created attachment 398671 [details]
Patch

[zalan]

> > Source/WebCore/page/Quirks.cpp:808
> > +    return isFirstSyntheticClickOnPage && (equalLettersIgnoringASCIICase(host, "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com"));
> 
> Surprised we don't have a helper for (equalLettersIgnoringASCIICase(host,
> "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com"))
> yet
I am going to add one in a dedicated patch.

[EWS]

Committed r261261: <https://trac.webkit.org/changeset/261261>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398671 [details].