Bug 211529 - [ContentObservation] Shutterstock search bar is not activated on the first tap
Summary: [ContentObservation] Shutterstock search bar is not activated on the first tap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks: 260006
  Show dependency tree / graph
 
Reported: 2020-05-06 14:24 PDT by zalan
Modified: 2023-08-09 19:51 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.47 KB, patch)
2020-05-06 14:53 PDT, zalan 		no flags Details | Formatted Diff | Diff
Patch (6.52 KB, patch)
2020-05-06 15:06 PDT, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description zalan 2020-05-06 14:24:01 PDT 
<rdar://problem/58843932>
Comment 1 zalan 2020-05-06 14:53:29 PDT 
Created attachment 398663 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-06 14:56:25 PDT 
Comment on attachment 398663 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398663&action=review

> Source/WebKit/ChangeLog:12
> +        Itâs very difficult to eliminate such false positives since all we see is that some (actionable)content is going away while some (actionable)content is being created.

(actionable)content

> Source/WebCore/page/Quirks.cpp:808
> +    return isFirstSyntheticClickOnPage && (equalLettersIgnoringASCIICase(host, "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com"));

Surprised we don't have a helper for (equalLettersIgnoringASCIICase(host, "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com")) yet

> Source/WebKit/WebProcess/WebPage/WebPage.cpp:3301
> +    m_hasHandledSyntheticClick = false;

Maybe add a comment saying that this is only used for a quirk, otherwise our future selves will forget.
Comment 3 zalan 2020-05-06 15:06:01 PDT 
Created attachment 398671 [details]
Patch
Comment 4 zalan 2020-05-06 15:06:40 PDT 
> > Source/WebCore/page/Quirks.cpp:808
> > +    return isFirstSyntheticClickOnPage && (equalLettersIgnoringASCIICase(host, "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com"));
> 
> Surprised we don't have a helper for (equalLettersIgnoringASCIICase(host,
> "shutterstock.com") || host.endsWithIgnoringASCIICase(".shutterstock.com"))
> yet
I am going to add one in a dedicated patch.
Comment 5 EWS 2020-05-06 17:18:07 PDT 
Committed r261261: <https://trac.webkit.org/changeset/261261>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398671 [details].