RESOLVED FIXED 211525
Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code 
https://bugs.webkit.org/show_bug.cgi?id=211525
Summary Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
Darin Adler
Reported 2020-05-06 12:35:41 PDT
Remove USE(INSERTION_UNDO_GROUPING) checks in macOS platform code
Attachments
Patch (29.98 KB, patch)
2020-05-06 12:47 PDT, Darin Adler 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Darin Adler
Comment 1 2020-05-06 12:47:19 PDT
Created attachment 398646 [details] Patch
Anders Carlsson
Comment 2 2020-05-07 07:03:14 PDT
Comment on attachment 398646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review > Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340 > -void PageClientImpl::registerInsertionUndoGrouping() Surprised that this can be removed when registerInsertionUndoGrouping() is pure virtual...
Wenson Hsieh
Comment 3 2020-05-07 08:51:00 PDT
Comment on attachment 398646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review >> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340 >> -void PageClientImpl::registerInsertionUndoGrouping() > > Surprised that this can be removed when registerInsertionUndoGrouping() is pure virtual... registerInsertionUndoGrouping() is only declared for PLATFORM(MAC).
Darin Adler
Comment 4 2020-05-07 11:21:38 PDT
Comment on attachment 398646 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398646&action=review >>> Source/WebKit/UIProcess/ios/PageClientImplIOS.mm:-340 >>> -void PageClientImpl::registerInsertionUndoGrouping() >> >> Surprised that this can be removed when registerInsertionUndoGrouping() is pure virtual... > > registerInsertionUndoGrouping() is only declared for PLATFORM(MAC). Yes, that’s right.
EWS
Comment 5 2020-05-07 11:37:37 PDT
Committed r261320: <https://trac.webkit.org/changeset/261320> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398646 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-07 11:38:16 PDT
<rdar://problem/62985963>
Note You need to log in before you can comment on or make changes to this bug.