[WebXR] Implement simulateUserActivation()
Created attachment 398622 [details] Patch
Comment on attachment 398622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/WebXRTest.cpp:105 > + function.handleEvent(); it might be better to follow Internals::withUserGesture. Something like: UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); function.handleEvent();
(In reply to youenn fablet from comment #2) > Comment on attachment 398622 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=398622&action=review > > > Source/WebCore/testing/WebXRTest.cpp:105 > > + function.handleEvent(); > > it might be better to follow Internals::withUserGesture. > Something like: > UserGestureIndicator gestureIndicator(ProcessingUserGesture, document); > function.handleEvent(); Much better indeed. I'll replace it before landing.
Committed r261273: <https://trac.webkit.org/changeset/261273>
<rdar://problem/62965108>
Comment on attachment 398622 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398622&action=review > Source/WebCore/testing/XRSimulateUserActivationFunction.h:42 > + virtual CallbackResult<void> handleEvent(void) = 0; This (void) syntax is never needed in C++. It is sometimes needed in old C code. Just use "()".