Bug 211497 - [GTK] Test failures after Flatpak upgrade
Summary: [GTK] Test failures after Flatpak upgrade
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-05 23:28 PDT by Diego Pino
Modified: 2020-05-07 06:43 PDT (History)
3 users (show)

See Also:


Attachments
Patch (4.27 KB, patch)
2020-05-07 05:26 PDT, Philippe Normand
aperez: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-05-05 23:28:21 PDT
The following tests started failing after upgrading to Flatpak (which happened in GTK Test Bot build #13542 (r260889)):

   fast/loader/local-CSS-from-local.html [ Failure ]
   fast/loader/local-JavaScript-from-local.html [ Failure ]
   fast/loader/local-image-from-local.html [ Failure ]
   http/tests/security/local-user-CSS-from-remote.html [ Failure ]
   webgl/1.0.3/conformance/glsl/bugs/sampler-array-using-loop-index.html [ Failure ]
   webgl/1.0.3/conformance/textures/texture-size-limit.html [ Failure ]

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r260889%20(13542)/results.html

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/loader/local-CSS-from-local-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/loader/local-CSS-from-local-actual.txt
@@ -3,4 +3,4 @@
 
 If the background is yellow then the CSS was loaded.
 
-Test Passed. Local CSS remotely loaded
+Test Failed: Local CSS not remotely loaded.


--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/loader/local-JavaScript-from-local-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/loader/local-JavaScript-from-local-actual.txt
@@ -1,4 +1,4 @@
 This test is to see if a local file can run a local script. 
 Currently this test cannot be run manually on Windows because we do not have a function like pathToLocalResource() outside of DRT. 
 
-Test Passed. Local script loaded and run.
+Test Failed: Local script not loaded.


--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/loader/local-image-from-local-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/loader/local-image-from-local-actual.txt
@@ -1,6 +1,6 @@
 This test is to see if a remote file can include a local image. 
 Currently this test cannot be run manually on Windows because we do not have a function like pathToLocalResource() outside of DRT. 
 
-Test Passed. Local image loaded.
+Test Failed: Image Load Error.

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/security/local-user-CSS-from-remote-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/http/tests/security/local-user-CSS-from-remote-actual.txt
@@ -2,4 +2,4 @@
 To run this test manually you must set your user style sheet in your Safari preferences to LayoutTests/http/tests/security/resources/cssStyle.css 
 If the background is yellow then the user stylesheet was loaded.
 
-Test Passed: Local user stylesheet loaded.
+Test Failed: Local user stylesheet not loaded into remote document.

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/webgl/1.0.3/conformance/glsl/bugs/sampler-array-using-loop-index-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/webgl/1.0.3/conformance/glsl/bugs/sampler-array-using-loop-index-actual.txt
@@ -1,5 +1,8 @@
 This test runs the WebGL Test listed below in an iframe and reports PASS or FAIL.
 
 Test: ../../../resources/webgl_test_files/conformance/glsl/bugs/sampler-array-using-loop-index.html
-[ PASS ] All tests passed
+[ 1: FAIL ] getError expected: NO_ERROR. Was INVALID_VALUE : Should be no errors from setup.
+[ 2: FAIL ] at (0, 0) expected: 64,32,16,9 was 32,16,8,0
+[ 3: PASS ] successfullyParsed is true
+[ FAIL ] 2 failures reported
Comment 1 Diego Pino 2020-05-05 23:42:56 PDT
Forgot this test which is timing out:

fast/dom/frame-loading-via-document-write.html [ Timeout ]

See: https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20(Tests)/r260889%20(13542)/fast/dom/frame-loading-via-document-write-diff.txt

--- /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/dom/frame-loading-via-document-write-expected.txt
+++ /home/slave/webkitgtk/gtk-linux-64-release-tests/build/layout-test-results/fast/dom/frame-loading-via-document-write-actual.txt
@@ -1,21 +1,2 @@
+FAIL: Timed out waiting for notifyDone to be called
 
-
---------
-Frame: 'topRow'
---------
-This page was successfully loaded.
-My protocol is file:
-My referrer is blank
-
-
---------
-Frame: 'middleRow'
---------
-Image loaded.
-
-
---------
-Frame: 'bottomRow'
---------
-Image loaded.
-
Comment 2 Philippe Normand 2020-05-07 04:58:34 PDT
the loader and http failures are related with the WEBKIT_TOP_LEVEL env var being set to /app instead of /app/webkit. I'm debugging this...
Comment 3 Philippe Normand 2020-05-07 05:26:04 PDT
Created attachment 398724 [details]
Patch
Comment 4 Philippe Normand 2020-05-07 06:42:56 PDT
Committed r261282: <https://trac.webkit.org/changeset/261282>
Comment 5 Radar WebKit Bug Importer 2020-05-07 06:43:13 PDT
<rdar://problem/62974721>