Bug 211495 - Better surfacing of the presenting parent PID in the Network process
Summary: Better surfacing of the presenting parent PID in the Network process
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Keith Rollin
Keywords: InRadar
Depends on:
Reported: 2020-05-05 22:17 PDT by Keith Rollin
Modified: 2020-05-06 13:35 PDT (History)
3 users (show)

See Also:

Patch (12.07 KB, patch)
2020-05-05 22:21 PDT, Keith Rollin
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Rollin 2020-05-05 22:17:31 PDT
In Bug 205295, NetworkResourceLoader logging was improved, with one of the changes being that the PID of parent process that invoked the Network process was logged at the start of NetworkResourceLoader::start(). However, there was an execution path that skipped calling start() (NetworkConnectionToWebProcess::scheduleResourceLoad -> NetworkResourceLoader ::startWithServiceWorker -> serviceWorkerDidNotHandle -> restartNetworkLoad -> startNetworkLoad), and so the the logging would not show the parent PID. This logging is needed for diagnostic purposes, so tweak the logging a little bit more in order to ensure we emit it. In this change, logging is added to various loading-related NetworkConnectionToWebProcess entry points (not just scheduleResourceLoad) in order to (a) ensure we emit the logging we want and (b) to give a clearer picture of what operations are being invoked in the Network process.
Comment 1 Radar WebKit Bug Importer 2020-05-05 22:17:43 PDT
Comment 2 Keith Rollin 2020-05-05 22:21:43 PDT
Created attachment 398592 [details]
Comment 3 EWS 2020-05-06 13:35:15 PDT
Committed r261249: <https://trac.webkit.org/changeset/261249>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398592 [details].