WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
211495
Better surfacing of the presenting parent PID in the Network process
https://bugs.webkit.org/show_bug.cgi?id=211495
Summary
Better surfacing of the presenting parent PID in the Network process
Keith Rollin
Reported
2020-05-05 22:17:31 PDT
In
Bug 205295
, NetworkResourceLoader logging was improved, with one of the changes being that the PID of parent process that invoked the Network process was logged at the start of NetworkResourceLoader::start(). However, there was an execution path that skipped calling start() (NetworkConnectionToWebProcess::scheduleResourceLoad -> NetworkResourceLoader ::startWithServiceWorker -> serviceWorkerDidNotHandle -> restartNetworkLoad -> startNetworkLoad), and so the the logging would not show the parent PID. This logging is needed for diagnostic purposes, so tweak the logging a little bit more in order to ensure we emit it. In this change, logging is added to various loading-related NetworkConnectionToWebProcess entry points (not just scheduleResourceLoad) in order to (a) ensure we emit the logging we want and (b) to give a clearer picture of what operations are being invoked in the Network process.
Attachments
Patch
(12.07 KB, patch)
2020-05-05 22:21 PDT
,
Keith Rollin
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2020-05-05 22:17:43 PDT
<
rdar://problem/62917205
>
Keith Rollin
Comment 2
2020-05-05 22:21:43 PDT
Created
attachment 398592
[details]
Patch
EWS
Comment 3
2020-05-06 13:35:15 PDT
Committed
r261249
: <
https://trac.webkit.org/changeset/261249
> All reviewed patches have been landed. Closing bug and clearing flags on
attachment 398592
[details]
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug