RESOLVED FIXED 211494
Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedContentArea into its own function 
https://bugs.webkit.org/show_bug.cgi?id=211494
Summary Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedConten...
Simon Fraser (smfr)
Reported 2020-05-05 22:04:32 PDT
Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedContentArea into its own function
Attachments
Patch (6.03 KB, patch)
2020-05-05 22:06 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Patch (6.03 KB, patch)
2020-05-05 22:40 PDT, Simon Fraser (smfr) 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 2020-05-05 22:06:38 PDT
Created attachment 398588 [details] Patch
Simon Fraser (smfr)
Comment 2 2020-05-05 22:40:28 PDT
Created attachment 398593 [details] Patch
Antti Koivisto
Comment 3 2020-05-06 07:56:28 PDT
Comment on attachment 398593 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398593&action=review > Source/WebCore/page/EventHandler.cpp:2627 > + if (elementUnderMouse) { > + frameView->mouseEnteredContentArea(); > + if (scrollableAreaForNodeUnderMouse) > + scrollableAreaForNodeUnderMouse->mouseEnteredContentArea(); > + } else { > + if (scrollableAreaForLastNode) > + scrollableAreaForLastNode->mouseExitedContentArea(); > + frameView->mouseExitedContentArea(); > + } > + return; You could early return instead of the else branch.
EWS
Comment 4 2020-05-06 08:30:20 PDT
Committed r261229: <https://trac.webkit.org/changeset/261229> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398593 [details].
Radar WebKit Bug Importer
Comment 5 2020-05-06 08:31:16 PDT
<rdar://problem/62931618>
Note You need to log in before you can comment on or make changes to this bug.