Bug 211494 - Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedContentArea into its own function
Summary: Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedConten...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Simon Fraser (smfr)
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-05 22:04 PDT by Simon Fraser (smfr)
Modified: 2020-05-06 08:31 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.03 KB, patch)
2020-05-05 22:06 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Patch (6.03 KB, patch)
2020-05-05 22:40 PDT, Simon Fraser (smfr) 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Fraser (smfr) 2020-05-05 22:04:32 PDT 
Factor EventHandler code that sends mouseEnteredContentArea/mouseExitedContentArea into its own function
Comment 1 Simon Fraser (smfr) 2020-05-05 22:06:38 PDT 
Created attachment 398588 [details]
Patch
Comment 2 Simon Fraser (smfr) 2020-05-05 22:40:28 PDT 
Created attachment 398593 [details]
Patch
Comment 3 Antti Koivisto 2020-05-06 07:56:28 PDT 
Comment on attachment 398593 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398593&action=review

> Source/WebCore/page/EventHandler.cpp:2627
> +        if (elementUnderMouse) {
> +            frameView->mouseEnteredContentArea();
> +            if (scrollableAreaForNodeUnderMouse)
> +                scrollableAreaForNodeUnderMouse->mouseEnteredContentArea();
> +        } else {
> +            if (scrollableAreaForLastNode)
> +                scrollableAreaForLastNode->mouseExitedContentArea();
> +            frameView->mouseExitedContentArea();
> +        }
> +        return;

You could early return instead of the else branch.
Comment 4 EWS 2020-05-06 08:30:20 PDT 
Committed r261229: <https://trac.webkit.org/changeset/261229>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398593 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-06 08:31:16 PDT 
<rdar://problem/62931618>