Bug 21149 - Make the concept of scrolling modes cross-platform
Summary: Make the concept of scrolling modes cross-platform
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 21083
  Show dependency treegraph
 
Reported: 2008-09-26 13:01 PDT by Dave Hyatt
Modified: 2008-09-26 13:53 PDT (History)
0 users

See Also:


Attachments
Patch (73.21 KB, patch)
2008-09-26 13:04 PDT, Dave Hyatt
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2008-09-26 13:01:59 PDT
Make the concept of the scrolling modes on ScrollView be cross-platform.
Comment 1 Dave Hyatt 2008-09-26 13:04:04 PDT
Created attachment 23856 [details]
Patch
Comment 2 Sam Weinig 2008-09-26 13:49:42 PDT
Comment on attachment 23856 [details]
Patch

+    if (WebCore::FrameView *view = frame? frame->view() : 0)
The * is on the wrong side and you need a space before the ?.

r=me.  God speed!
Comment 3 Dave Hyatt 2008-09-26 13:53:23 PDT
Fixed in r36962.