[Quirk] Job listing page goes blank when scrolling on stackoverflow.com

[zalan]

<rdar://problem/62558405>

[zalan]

Created attachment 398572 [details]
Patch

[Wenson Hsieh]

Comment on attachment 398572 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398572&action=review

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1370
> +static RecommedDesktopClassBrowsingForRequest desktopClassBrowsingRecommendedForRequest(const WebCore::ResourceRequest& request)

“Recommed"

> Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1443
> +        return RecommedDesktopClassBrowsingForRequest::Always;

Nit - it’s not immediately obvious to me what the difference between Always and Yes is, and I find the asymmetry between No and Yes a bit odd. That said, it’s admittedly hard to come up with a good name for this :/

What do you think about just No, Yes, Auto?

[zalan]

(In reply to Wenson Hsieh from comment #2)
> Comment on attachment 398572 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398572&action=review
> 
> > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1370
> > +static RecommedDesktopClassBrowsingForRequest desktopClassBrowsingRecommendedForRequest(const WebCore::ResourceRequest& request)
> 
> “Recommed"
> 
> > Source/WebKit/UIProcess/ios/WebPageProxyIOS.mm:1443
> > +        return RecommedDesktopClassBrowsingForRequest::Always;
> 
> Nit - it’s not immediately obvious to me what the difference between Always
> and Yes is, and I find the asymmetry between No and Yes a bit odd. That
> said, it’s admittedly hard to come up with a good name for this :/
> 
> What do you think about just No, Yes, Auto?
Yeah I wasn't too happy about the naming either. Let me think a bit.

[zalan]

Created attachment 398576 [details]
Patch

[EWS]

Committed r261209: <https://trac.webkit.org/changeset/261209>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398576 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62914831>