Bug 211473 - fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS
Summary: fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-05 14:51 PDT by Chris Dumez
Modified: 2020-08-24 12:23 PDT (History)
2 users (show)

See Also:

Attachments
Patch (3.23 KB, patch)
2020-05-05 14:55 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.27 KB, patch)
2020-05-05 15:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-05-05 14:51:40 PDT 
fast/overflow/horizontal-scroll-after-back.html is a flaky timeout on macOS.
Comment 1 Chris Dumez 2020-05-05 14:55:39 PDT 
<rdar://problem/61180247>
Comment 2 Chris Dumez 2020-05-05 14:55:47 PDT 
Created attachment 398554 [details]
Patch
Comment 3 Darin Adler 2020-05-05 15:06:12 PDT 
Comment on attachment 398554 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398554&action=review

> LayoutTests/fast/overflow/horizontal-scroll-after-back.html:20
> +    window.sessionStorage.horizontal_scroll_after_back_test_started = true;

I don’t think we need the "window." here.

> LayoutTests/fast/overflow/horizontal-scroll-after-back.html:30
> +    window.setTimeout("navigateAwayAndBack()", 0);

I don’t think we need the "window." here.

> LayoutTests/fast/overflow/horizontal-scroll-after-back.html:37
> +    if (!window.sessionStorage.horizontal_scroll_after_back_test_started)
> +        return;
> +    delete window.sessionStorage.horizontal_scroll_after_back_test_started;

I don’t think we need the "window." here.
Comment 4 Chris Dumez 2020-05-05 15:07:32 PDT 
Created attachment 398556 [details]
Patch
Comment 5 EWS 2020-05-05 16:12:35 PDT 
Committed r261205: <https://trac.webkit.org/changeset/261205>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398556 [details].