Bug 211456 - Fix urlsearchparams-delete.html
Summary: Fix urlsearchparams-delete.html
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
: 193022 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-05 11:16 PDT by Rob Buis
Modified: 2022-01-22 16:03 PST (History)
7 users (show)

See Also:

Attachments
Patch (2.86 KB, patch)
2020-05-05 11:21 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (3.11 KB, patch)
2020-05-08 10:09 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Patch (1.95 KB, patch)
2020-05-08 12:49 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-05-05 11:16:55 PDT 
Fix urlsearchparams-delete.html by unconditionally calling
the update steps as specified in Step 2:
https://url.spec.whatwg.org/#dom-urlsearchparams-delete
Comment 1 Rob Buis 2020-05-05 11:21:53 PDT 
Created attachment 398530 [details]
Patch
Comment 2 Daniel Bates 2020-05-07 10:38:13 PDT 
Comment on attachment 398530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398530&action=review

> Source/WebCore/ChangeLog:7
> +

Patch is ok as-is. No change needed. A better patch would explain the bug fix here.
Comment 3 Rob Buis 2020-05-08 10:09:43 PDT 
Created attachment 398870 [details]
Patch
Comment 4 EWS 2020-05-08 10:57:59 PDT 
Committed r261399: <https://trac.webkit.org/changeset/261399>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398870 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-08 10:58:15 PDT 
<rdar://problem/63027766>
Comment 6 Rob Buis 2020-05-08 12:48:29 PDT 
Comment on attachment 398530 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398530&action=review

>> Source/WebCore/ChangeLog:7
>> +
> 
> Patch is ok as-is. No change needed. A better patch would explain the bug fix here.

Yes, I am not sure what happened there :) Anyway added it before landing.
Comment 7 Rob Buis 2020-05-08 12:49:39 PDT 
Reopening to attach new patch.
Comment 8 Rob Buis 2020-05-08 12:49:42 PDT 
Created attachment 398884 [details]
Patch
Comment 9 Rob Buis 2020-05-09 09:01:19 PDT 
Oops, uploaded to wrong bug.
Comment 10 Yusuke Suzuki 2022-01-22 16:03:22 PST 
*** Bug 193022 has been marked as a duplicate of this bug. ***