Bug 211454 - Remove orphaned WPT expectations & unused harness
Summary: Remove orphaned WPT expectations & unused harness
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Enhancement
Assignee: Alexey Shvayka
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-05 09:57 PDT by Alexey Shvayka
Modified: 2020-05-06 09:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (1.78 MB, patch)
2020-05-05 10:27 PDT, Alexey Shvayka 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Shvayka 2020-05-05 09:57:10 PDT Comment hidden (obsolete)
Comment 1 Alexey Shvayka 2020-05-05 10:27:32 PDT 
Created attachment 398523 [details]
Patch
Comment 2 Alexey Shvayka 2020-05-05 16:58:23 PDT 
(In reply to Alexey Shvayka from comment #1)
> Created attachment 398523 [details]
> Patch

Thanks for review!

With this patch, we still have 3 copies of idlharness.js and WebIDLParser.js (each): at LayoutTests/resources, LayoutTests/imported/w3c/web-platform-tests/resources, and for a few tests imported from Opera (currently skipped).

I wonder if it's a good idea to remove outdated versions and use only WPT upstream ones? There are only a 3-4 non-imported tests that use idlharness.js and interfaces they are testing are probably covered by WPT.

Apart from saving bandwidth, the upside is always being up to date with WebIDL spec and avoid partly "syncing" idlharness.js like we did in r260992. Downside: when syncing wpt/resources, expectations for a few non-imported tests should be updated.
Comment 3 EWS 2020-05-06 09:29:08 PDT 
Committed r261235: <https://trac.webkit.org/changeset/261235>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398523 [details].
Comment 4 Radar WebKit Bug Importer 2020-05-06 09:30:17 PDT 
<rdar://problem/62933559>