Bug 211449 - Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back navigation in an iframe
Summary: Regression (iOS 13.4, r249142): WKWebView.loading is never reset after a Back...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alex Christensen
Keywords: InRadar
Depends on:
Reported: 2020-05-05 08:51 PDT by Ali Juma
Modified: 2020-05-15 14:31 PDT (History)
6 users (show)

See Also:

Test case (185 bytes, text/html)
2020-05-05 08:51 PDT, Ali Juma
no flags Details
Patch (5.74 KB, patch)
2020-05-15 13:33 PDT, Alex Christensen
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ali Juma 2020-05-05 08:51:41 PDT
Created attachment 398515 [details]
Test case

Steps to reproduce:
1. Tap on a link in an iframe, that navigates the iframe (rather than the main frame)
2. Go back

Expected result: After (2) completes, WKWebView.loading becomes NO

Actual result: WKWebView.loading is stuck at YES until the next navigation

On Safari on iOS 13.4, this bug causes the blue loading bar to remain visible after (2) is complete.
Comment 1 Radar WebKit Bug Importer 2020-05-05 09:16:43 PDT
Comment 2 Ali Juma 2020-05-08 13:27:38 PDT
This is happening because PageLoadState::setPendingAPIRequest is called during WebPageProxy::goToBackForwardItem, but the pending API request is never cleared. In WebPageProxy::didStartProvisionalLoadForFrameShared, |navigation| is null, so we don't call PageLoadState::clearPendingAPIRequest.

The |navigation| is null because in WebPageProxy::goToBackForwardItem, we only create an API::Navigation if the target item isn't considered same-document wrt the current item.

So this bug is a regression from r249142, which changed WebPageProxy::didStartProvisionalLoadForFrameShared to only call clearPendingAPIRequest if |navigation| is non-null.
Comment 3 Alex Christensen 2020-05-15 13:33:26 PDT
Created attachment 399506 [details]
Comment 4 Geoffrey Garen 2020-05-15 13:45:05 PDT
Comment on attachment 399506 [details]

Comment 5 EWS 2020-05-15 14:31:25 PDT
Committed r261761: <https://trac.webkit.org/changeset/261761>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 399506 [details].