Bug 211409 - Tapping to focus editable elements should start caret selection at word boundary
Summary: Tapping to focus editable elements should start caret selection at word boundary
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 16:00 PDT by Wenson Hsieh
Modified: 2020-05-04 19:45 PDT (History)
7 users (show)

See Also:


Attachments
For EWS (23.08 KB, patch)
2020-05-04 16:13 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff
Patch (23.08 KB, patch)
2020-05-04 17:32 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-04 16:00:26 PDT Comment hidden (obsolete)
Comment 1 Wenson Hsieh 2020-05-04 16:13:31 PDT Comment hidden (obsolete)
Comment 2 Wenson Hsieh 2020-05-04 17:32:36 PDT
Created attachment 398441 [details]
Patch
Comment 3 Wenson Hsieh 2020-05-04 17:32:57 PDT
<rdar://problem/62869098>
Comment 4 Megan Gardner 2020-05-04 18:16:18 PDT
Comment on attachment 398441 [details]
Patch

Great renaming and refactoring. I was on the fence about the WordIsNearTap flag, but I convinced myself that you are right.
Comment 5 Daniel Bates 2020-05-04 18:17:26 PDT
Patch is ok as is. No change needed. Code is optimal as is, there is an Apple internal reason. Ping me or wait for bug to drop.
Comment 6 EWS 2020-05-04 19:45:28 PDT
Committed r261139: <https://trac.webkit.org/changeset/261139>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398441 [details].