Bug 211397 - Excessive error logging from daemons trying to use WebKit, under -[UIDevice currentDevice]
Summary: Excessive error logging from daemons trying to use WebKit, under -[UIDevice c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 14:01 PDT by Tim Horton
Modified: 2020-05-05 02:03 PDT (History)
6 users (show)

See Also:

Attachments
Patch (4.10 KB, patch)
2020-05-04 14:01 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (5.64 KB, patch)
2020-05-05 00:42 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (5.63 KB, patch)
2020-05-05 00:43 PDT, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2020-05-04 14:01:02 PDT 
Excessive error logging from daemons trying to use WebKit, under -[UIDevice currentDevice]
Comment 1 Tim Horton 2020-05-04 14:01:17 PDT 
Created attachment 398409 [details]
Patch
Comment 2 Tim Horton 2020-05-04 14:01:19 PDT 
<rdar://problem/61635403>
Comment 3 EWS 2020-05-04 15:11:47 PDT 
Committed r261117: <https://trac.webkit.org/changeset/261117>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398409 [details].
Comment 4 Tim Horton 2020-05-04 18:18:45 PDT 
Reverted r261117 for reason:

broke

Committed r261135: <https://trac.webkit.org/changeset/261135>
Comment 5 Darin Adler 2020-05-04 23:52:55 PDT 
Comment on attachment 398409 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398409&action=review

> Source/WebKit/Shared/UserInterfaceIdiom.mm:46
> +    // If we are in a dameon, we cannot use UIDevice. Fall back to checking the hardware itself.

typo in "daemon" here
Comment 6 Tim Horton 2020-05-05 00:42:32 PDT 
Created attachment 398487 [details]
Patch
Comment 7 Tim Horton 2020-05-05 00:43:30 PDT 
Created attachment 398488 [details]
Patch
Comment 8 EWS 2020-05-05 02:03:25 PDT 
Committed r261157: <https://trac.webkit.org/changeset/261157>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398488 [details].