Bug 211392 - Stop hard-coding get-task-allow entitlement for simulator builds
Summary: Stop hard-coding get-task-allow entitlement for simulator builds
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-04 12:48 PDT by Chris Dumez
Modified: 2020-05-04 15:09 PDT (History)
5 users (show)

See Also:

Attachments
Patch (2.75 KB, patch)
2020-05-04 12:49 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Patch (3.99 KB, patch)
2020-05-04 13:07 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-05-04 12:48:15 PDT 
Stop hard-coding get-task-allow entitlement for simulator builds and let Xcode inject it as needed.
Comment 1 Chris Dumez 2020-05-04 12:49:11 PDT 
Created attachment 398402 [details]
Patch
Comment 2 Chris Dumez 2020-05-04 13:07:07 PDT 
Created attachment 398405 [details]
Patch
Comment 3 Chris Dumez 2020-05-04 14:52:42 PDT 
Comment on attachment 398405 [details]
Patch

Ok, I have validated the change locally. Turns out that the get-task-allow entitlement gets added to the signature and thus applies to the host system, while the runningboard entitlement gets added to the __entitlement section of the binary and thus only applies inside the simulator.
Comment 4 Geoffrey Garen 2020-05-04 15:06:38 PDT 
Comment on attachment 398405 [details]
Patch

r=me
Comment 5 EWS 2020-05-04 15:08:50 PDT 
Committed r261116: <https://trac.webkit.org/changeset/261116>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398405 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-04 15:09:19 PDT 
<rdar://problem/62863915>