RESOLVED FIXED 211392
Stop hard-coding get-task-allow entitlement for simulator builds 
https://bugs.webkit.org/show_bug.cgi?id=211392
Summary Stop hard-coding get-task-allow entitlement for simulator builds
Chris Dumez
Reported 2020-05-04 12:48:15 PDT
Stop hard-coding get-task-allow entitlement for simulator builds and let Xcode inject it as needed.
Attachments
Patch (2.75 KB, patch)
2020-05-04 12:49 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (3.99 KB, patch)
2020-05-04 13:07 PDT, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2020-05-04 12:49:11 PDT
Created attachment 398402 [details] Patch
Chris Dumez
Comment 2 2020-05-04 13:07:07 PDT
Created attachment 398405 [details] Patch
Chris Dumez
Comment 3 2020-05-04 14:52:42 PDT
Comment on attachment 398405 [details] Patch Ok, I have validated the change locally. Turns out that the get-task-allow entitlement gets added to the signature and thus applies to the host system, while the runningboard entitlement gets added to the __entitlement section of the binary and thus only applies inside the simulator.
Geoffrey Garen
Comment 4 2020-05-04 15:06:38 PDT
Comment on attachment 398405 [details] Patch r=me
EWS
Comment 5 2020-05-04 15:08:50 PDT
Committed r261116: <https://trac.webkit.org/changeset/261116> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398405 [details].
Radar WebKit Bug Importer
Comment 6 2020-05-04 15:09:19 PDT
<rdar://problem/62863915>
Note You need to log in before you can comment on or make changes to this bug.