Bug 211368 - Remove some unused and broken functions in Bitmap.
Summary: Remove some unused and broken functions in Bitmap.
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
Keywords: InRadar
Depends on:
Reported: 2020-05-03 23:22 PDT by Mark Lam
Modified: 2020-05-04 00:16 PDT (History)
6 users (show)

See Also:

proposed patch. (2.82 KB, patch)
2020-05-03 23:34 PDT, Mark Lam
ysuzuki: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2020-05-03 23:22:15 PDT
Bitmap::operator[] never worked.  There's currently no way to use it to read a bit value.  We also can't use it to set a bit value because it relies on Bitmap::iterator::operator= to set the value.  However, Bitmap::iterator stores the Bitmap* as a const pointer, and Bitmap::iterator::operator= calls set() on the const pointer.  If we try to use operator[] to set a bit, we'll get a compilation error.

This patch removes the 2 variants of Bitmap::operator[] and Bitmap::iterator::operator=.
Comment 1 Mark Lam 2020-05-03 23:34:12 PDT
Created attachment 398348 [details]
proposed patch.
Comment 2 Yusuke Suzuki 2020-05-04 00:01:25 PDT
Comment on attachment 398348 [details]
proposed patch.

Comment 3 Mark Lam 2020-05-04 00:15:58 PDT
Thanks for the review.  Landed in r261073: <http://trac.webkit.org/r261073>.
Comment 4 Radar WebKit Bug Importer 2020-05-04 00:16:15 PDT