Bug 211359 - [Intl] Alphabetize extension keys and correctly mark const methods
Summary: [Intl] Alphabetize extension keys and correctly mark const methods
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-03 13:58 PDT by Ross Kirsling
Modified: 2020-05-05 11:22 PDT (History)
9 users (show)

See Also:

Attachments
Patch (20.61 KB, patch)
2020-05-03 14:33 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Patch for landing (20.58 KB, patch)
2020-05-05 10:40 PDT, Ross Kirsling 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-05-03 13:58:41 PDT 
[Intl] Alphabetize extension keys and correctly mark const methods
Comment 1 Ross Kirsling 2020-05-03 14:33:49 PDT 
Created attachment 398333 [details]
Patch
Comment 2 Darin Adler 2020-05-05 10:29:42 PDT 
Comment on attachment 398333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398333&action=review

> Source/JavaScriptCore/runtime/IntlCollator.cpp:47
> +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" };

There’s a redundant const here. Given constexpr, don’t need the const after the "*".
Comment 3 Ross Kirsling 2020-05-05 10:39:59 PDT 
(In reply to Darin Adler from comment #2)
> Comment on attachment 398333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398333&action=review
> 
> > Source/JavaScriptCore/runtime/IntlCollator.cpp:47
> > +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" };
> 
> There’s a redundant const here. Given constexpr, don’t need the const after
> the "*".

Oops, thanks for pointing that out! Looks like a typo from an earlier patch.
Comment 4 Ross Kirsling 2020-05-05 10:40:53 PDT 
Created attachment 398527 [details]
Patch for landing
Comment 5 EWS 2020-05-05 11:21:38 PDT 
Committed r261182: <https://trac.webkit.org/changeset/261182>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398527 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-05 11:22:17 PDT 
<rdar://problem/62895849>