Bug 211359 – [Intl] Alphabetize extension keys and correctly mark const methods

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

[Intl] Alphabetize extension keys and correctly mark const methods

[Ross Kirsling]

Created attachment 398333 [details]
Patch

[Darin Adler]

Comment on attachment 398333 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398333&action=review

> Source/JavaScriptCore/runtime/IntlCollator.cpp:47
> +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" };

There’s a redundant const here. Given constexpr, don’t need the const after the "*".

[Ross Kirsling]

(In reply to Darin Adler from comment #2)
> Comment on attachment 398333 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398333&action=review
> 
> > Source/JavaScriptCore/runtime/IntlCollator.cpp:47
> > +constexpr const char* const relevantExtensionKeys[3] = { "co", "kf", "kn" };
> 
> There’s a redundant const here. Given constexpr, don’t need the const after
> the "*".

Oops, thanks for pointing that out! Looks like a typo from an earlier patch.

[Ross Kirsling]

Created attachment 398527 [details]
Patch for landing

[EWS]

Committed r261182: <https://trac.webkit.org/changeset/261182>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398527 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62895849>