Bug 211356 - Put lh / rlh units behind a flag until bug 211351 is sorted out.
Summary: Put lh / rlh units behind a flag until bug 211351 is sorted out.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Emilio Cobos Álvarez (:emilio)
URL:
Keywords: InRadar
Depends on:
Blocks: 211351
  Show dependency tree / graph
 
Reported: 2020-05-03 12:18 PDT by Emilio Cobos Álvarez (:emilio)
Modified: 2023-01-03 13:26 PST (History)
11 users (show)

See Also:

Attachments
Patch (14.65 KB, patch)
2020-05-03 12:29 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Patch (14.66 KB, patch)
2020-05-03 13:34 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Patch (15.33 KB, patch)
2020-05-03 14:24 PDT, Emilio Cobos Álvarez (:emilio) 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Emilio Cobos Álvarez (:emilio) 2020-05-03 12:18:15 PDT 
See bug 211351 and the referenced CSSWG issue.
Comment 1 Emilio Cobos Álvarez (:emilio) 2020-05-03 12:29:31 PDT 
Created attachment 398323 [details]
Patch
Comment 2 Emilio Cobos Álvarez (:emilio) 2020-05-03 13:34:46 PDT 
Created attachment 398329 [details]
Patch
Comment 3 Emilio Cobos Álvarez (:emilio) 2020-05-03 14:24:09 PDT 
Created attachment 398331 [details]
Patch
Comment 4 EWS 2020-05-04 00:16:54 PDT 
Committed r261074: <https://trac.webkit.org/changeset/261074>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398331 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-04 00:17:16 PDT 
<rdar://problem/62834090>
Comment 6 Myles C. Maxfield 2023-01-03 11:43:29 PST 
Soooo, sounds like this patch should be reverted, because bug 211351 is sorted out? (Or the flag should be flipped to on-by-default?)
Comment 7 Tim Nguyen (:ntim) 2023-01-03 13:26:17 PST 
(In reply to Myles C. Maxfield from comment #6)
> Soooo, sounds like this patch should be reverted, because bug 211351 is
> sorted out? (Or the flag should be flipped to on-by-default?)

It was done in October: https://bugs.webkit.org/show_bug.cgi?id=246522