Bug 211348 - Sometimes cannot find <textarea> in list of editable elements
Summary: Sometimes cannot find <textarea> in list of editable elements
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-03 00:49 PDT by Daniel Bates
Modified: 2020-05-03 13:53 PDT (History)
8 users (show)

See Also:

Attachments
Patch (17.02 KB, patch)
2020-05-03 01:06 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (17.08 KB, patch)
2020-05-03 01:18 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (17.91 KB, patch)
2020-05-03 13:52 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-05-03 00:49:39 PDT 
Consider a page with the following markup:

[[
<textarea style="width: 500px; height: 500px">So few words to fill such a big space...</textarea>
]]

If you call Page::editableElementsInRect() (directly or via -_requestTextInputContextsInRect:completionHandler:) with a rect that is in an empty part of the <textarea> then it will NOT find it. But it should find it.

Need to add form control bounds to editable region instead of the bounds of its inner text element.
Comment 1 Daniel Bates 2020-05-03 00:49:47 PDT 
<rdar://problem/62231067>
Comment 2 Daniel Bates 2020-05-03 01:06:53 PDT 
Created attachment 398307 [details]
Patch
Comment 3 Daniel Bates 2020-05-03 01:18:10 PDT 
Created attachment 398308 [details]
Patch
Comment 4 Daniel Bates 2020-05-03 06:59:43 PDT 
Just need to rebase results of some tests...
Comment 5 Daniel Bates 2020-05-03 13:52:53 PDT 
Created attachment 398330 [details]
To Land
Comment 6 Daniel Bates 2020-05-03 13:53:29 PDT 
Committed r261065: <https://trac.webkit.org/changeset/261065>
Comment 7 Daniel Bates 2020-05-03 13:53:51 PDT 
BTW thanks for the review, Simon!