Bug 211319 - Add a test for webkit.org/b/211311
Summary: Add a test for webkit.org/b/211311
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Wenson Hsieh
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-01 13:42 PDT by Wenson Hsieh
Modified: 2020-05-01 16:12 PDT (History)
7 users (show)

See Also:


Attachments
Patch (7.04 KB, patch)
2020-05-01 14:05 PDT, Wenson Hsieh
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Wenson Hsieh 2020-05-01 13:42:16 PDT
SSIA
Comment 1 Wenson Hsieh 2020-05-01 13:46:35 PDT
Test for rdar://62663459
Comment 2 Wenson Hsieh 2020-05-01 14:05:52 PDT
Created attachment 398235 [details]
Patch
Comment 3 Darin Adler 2020-05-01 14:10:33 PDT
Comment on attachment 398235 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398235&action=review

> Tools/TestWebKitAPI/Tests/mac/AttributedString.mm:100
> +    virtual void didLoadURL(WKView *wkView) { }

I don’t understand this. Is this just the way to write a legacy-WebKit-only test?
Comment 4 Wenson Hsieh 2020-05-01 14:12:56 PDT
(In reply to Darin Adler from comment #3)
> Comment on attachment 398235 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=398235&action=review
> 
> > Tools/TestWebKitAPI/Tests/mac/AttributedString.mm:100
> > +    virtual void didLoadURL(WKView *wkView) { }
> 
> I don’t understand this. Is this just the way to write a legacy-WebKit-only
> test?

It isn’t the only way to test WebKitLegacy, but it’s the way these other attributed string tests in this file work, so I decided to go with the existing pattern.
Comment 5 EWS 2020-05-01 16:12:11 PDT
Committed r261037: <https://trac.webkit.org/changeset/261037>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398235 [details].