WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
211309
Avoid unnecessary copying in AnimationTimeline and other clean ups
https://bugs.webkit.org/show_bug.cgi?id=211309
Summary
Avoid unnecessary copying in AnimationTimeline and other clean ups
Daniel Bates
Reported
2020-05-01 12:13:56 PDT
On random code inspection noticed that AnimationTimeline::relevantAnimations() and ::allAnimations() are copying into a new Vector. They don't need to. Moreover, allAnimations() isn't being used, so I was tempted to remove, but maybe it will be used soon?
Attachments
Patch
(3.56 KB, patch)
2020-05-01 12:21 PDT
,
Daniel Bates
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Daniel Bates
Comment 1
2020-05-01 12:21:05 PDT
Created
attachment 398216
[details]
Patch
Daniel Bates
Comment 2
2020-05-01 15:17:03 PDT
Comment on
attachment 398216
[details]
Patch Clearing flags on attachment: 398216 Committed
r261029
: <
https://trac.webkit.org/changeset/261029
>
Daniel Bates
Comment 3
2020-05-01 15:17:07 PDT
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 4
2020-05-01 15:18:17 PDT
<
rdar://problem/62749337
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug