Bug 211309 - Avoid unnecessary copying in AnimationTimeline and other clean ups
Summary: Avoid unnecessary copying in AnimationTimeline and other clean ups
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-05-01 12:13 PDT by Daniel Bates
Modified: 2020-05-01 15:18 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.56 KB, patch)
2020-05-01 12:21 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-05-01 12:13:56 PDT
On random code inspection noticed that AnimationTimeline::relevantAnimations() and ::allAnimations() are copying into a new Vector. They don't need to.

Moreover, allAnimations() isn't being used, so I was tempted to remove, but maybe it will be used soon?
Comment 1 Daniel Bates 2020-05-01 12:21:05 PDT
Created attachment 398216 [details]
Patch
Comment 2 Daniel Bates 2020-05-01 15:17:03 PDT
Comment on attachment 398216 [details]
Patch

Clearing flags on attachment: 398216

Committed r261029: <https://trac.webkit.org/changeset/261029>
Comment 3 Daniel Bates 2020-05-01 15:17:07 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-05-01 15:18:17 PDT
<rdar://problem/62749337>