RESOLVED FIXED 211307
Text manipulation should observe the value attribute of some input elements 
https://bugs.webkit.org/show_bug.cgi?id=211307
Summary Text manipulation should observe the value attribute of some input elements
Wenson Hsieh
Reported 2020-05-01 12:10:52 PDT
<rdar://problem/61568528>
Attachments
Patch (5.36 KB, patch)
2020-05-01 15:10 PDT, Wenson Hsieh 		darin: review+
DetailsFormatted DiffDiff
Patch for landing (5.35 KB, patch)
2020-05-01 18:48 PDT, Wenson Hsieh 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2020-05-01 15:10:10 PDT
Created attachment 398246 [details] Patch
Darin Adler
Comment 2 2020-05-01 18:39:38 PDT
Comment on attachment 398246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398246&action=review > Source/WebCore/editing/TextManipulationController.cpp:233 > + if (nameToCheck == valueAttr.get() && is<HTMLInputElement>(element)) > + return downcast<HTMLInputElement>(element).isTextButton(); I would write: if (nameToCheck == valueAttr) return is<HTMLInputElement>(element) && downcast<HTMLInputElement>(element).isTextButton();
Wenson Hsieh
Comment 3 2020-05-01 18:43:24 PDT
Comment on attachment 398246 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398246&action=review >> Source/WebCore/editing/TextManipulationController.cpp:233 >> + return downcast<HTMLInputElement>(element).isTextButton(); > > I would write: > > if (nameToCheck == valueAttr) > return is<HTMLInputElement>(element) && downcast<HTMLInputElement>(element).isTextButton(); Sounds good!
Wenson Hsieh
Comment 4 2020-05-01 18:48:00 PDT
Created attachment 398269 [details] Patch for landing
EWS
Comment 5 2020-05-01 19:26:28 PDT
Committed r261042: <https://trac.webkit.org/changeset/261042> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398269 [details].
Note You need to log in before you can comment on or make changes to this bug.