Bug 211290 - Receiving WebRTC network packets should not go through the main thread
Summary: Receiving WebRTC network packets should not go through the main thread
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: youenn fablet
URL:
Keywords: InRadar
Depends on: 211924
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-01 07:27 PDT by youenn fablet
Modified: 2021-02-17 11:24 PST (History)
9 users (show)

See Also:


Attachments
Patch (40.67 KB, patch)
2020-05-01 07:44 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (40.95 KB, patch)
2020-05-01 09:30 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (47.78 KB, patch)
2020-05-01 10:17 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch (47.83 KB, patch)
2020-05-04 08:01 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
Patch for landing (48.07 KB, patch)
2020-05-05 01:18 PDT, youenn fablet
no flags Details | Formatted Diff | Diff
WinCairo build fix (48.07 KB, patch)
2020-05-05 02:53 PDT, youenn fablet
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description youenn fablet 2020-05-01 07:27:11 PDT
Receiving WebRTC network packets should not go through the main thread
Comment 1 youenn fablet 2020-05-01 07:44:32 PDT
Created attachment 398184 [details]
Patch
Comment 2 youenn fablet 2020-05-01 09:30:56 PDT
Created attachment 398190 [details]
Patch
Comment 3 youenn fablet 2020-05-01 10:17:07 PDT
Created attachment 398196 [details]
Patch
Comment 4 youenn fablet 2020-05-04 08:01:35 PDT
Created attachment 398362 [details]
Patch
Comment 5 Alex Christensen 2020-05-04 10:22:30 PDT
Comment on attachment 398362 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398362&action=review

> Source/WebKit/WebProcess/Network/webrtc/LibWebRTCNetwork.cpp:119
> +    if (auto* socket = m_socketFactory.socket(identifier))

You should probably add assertions to these.
ASSERT(!RunLoop::isMain());
Comment 6 youenn fablet 2020-05-05 01:18:07 PDT
Created attachment 398489 [details]
Patch for landing
Comment 7 youenn fablet 2020-05-05 02:53:43 PDT
Created attachment 398494 [details]
WinCairo build fix
Comment 8 EWS 2020-05-05 06:40:09 PDT
Committed r261163: <https://trac.webkit.org/changeset/261163>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398494 [details].
Comment 9 Radar WebKit Bug Importer 2020-05-05 06:41:13 PDT
<rdar://problem/62886328>