Bug 211281 - [Flatpak SDK] Query the doc portal path with DBus
Summary: [Flatpak SDK] Query the doc portal path with DBus
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on: 211371
Blocks:
  Show dependency treegraph
 
Reported: 2020-05-01 03:14 PDT by Philippe Normand
Modified: 2020-05-20 01:16 PDT (History)
4 users (show)

See Also:


Attachments
Patch (3.30 KB, patch)
2020-05-01 03:17 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff
Patch (4.26 KB, patch)
2020-05-01 03:26 PDT, Philippe Normand
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2020-05-01 03:14:06 PDT
.
Comment 1 Philippe Normand 2020-05-01 03:17:16 PDT
Created attachment 398170 [details]
Patch
Comment 2 Philippe Normand 2020-05-01 03:26:24 PDT
Created attachment 398171 [details]
Patch
Comment 3 Lauro Moura 2020-05-01 06:08:36 PDT
Patch looks good, no problem testing locally.
Comment 4 EWS 2020-05-04 01:23:49 PDT
Committed r261076: <https://trac.webkit.org/changeset/261076>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398171 [details].
Comment 5 Radar WebKit Bug Importer 2020-05-04 01:24:14 PDT
<rdar://problem/62835591>
Comment 6 WebKit Commit Bot 2020-05-04 01:56:27 PDT
Re-opened since this is blocked by bug 211371
Comment 7 Philippe Normand 2020-05-04 01:57:31 PDT
perl ./Tools/Scripts/update-webkitgtk-libs --release
 in dir /home/slave/webkitgtk/gtk-linux-64-release/build (timeout 1200 secs)
 watching logfiles {}
 argv: ['perl', './Tools/Scripts/update-webkitgtk-libs', '--release']
 environment:
  HOME=/home/slave
  JHBUILD_MIRROR=/home/slave/webkitgtk/jhbuild-mirror
  LANG=en_US.UTF-8
  LOGNAME=slave
  MAIL=/var/mail/slave
  NUMBER_OF_PROCESSORS=8
  PATH=/etc/zipwrapper:/usr/lib/ccache:/usr/lib/gold-ld:/sbin:/usr/sbin:/bin:/usr/bin
  PWD=/home/slave/webkitgtk/gtk-linux-64-release/build
  SHELL=/bin/bash
  TERM=dumb
  TZ=PST8PDT
  USER=slave
  WEBKIT_CORE_DUMPS_DIRECTORY=/var/www/cores/bb-webkit-release-build-64
  WEBKIT_JHBUILD=0
  WEBKIT_TEST_CHILD_PROCESSES=8
  XDG_RUNTIME_DIR=/run/user/1000
 using PTY: True
Updating Flatpak Release environment
Installing from flathub org.freedesktop.Platform.ffmpeg-full x86_64 19.08
Looking for matches…


 1.	   	org.freedesktop.Platform.ffmpeg-full	19.08	i	flathub	< 3.6 MB



Installing…                                                                        
Installing… █████████▍            47%
Installing… ████████████████████ 100%  3.4 MB/s
Installation complete.                                                               

Traceback (most recent call last):
  File "Tools/Scripts/update-webkit-flatpak", line 28, in <module>
    WebkitFlatpak.load_from_args(["--update"] + sys.argv[1:]).run()
  File "./Tools/flatpak/flatpakutils.py", line 838, in run
    return self.main()
  File "./Tools/flatpak/flatpakutils.py", line 830, in main
    self.setup_icecc("gcc")
  File "./Tools/flatpak/flatpakutils.py", line 856, in setup_icecc
    self.run_in_sandbox('icecc', '--build-native', toolchain_path, stdout=tmpfile, cwd=self.source_root)
  File "./Tools/flatpak/flatpakutils.py", line 691, in run_in_sandbox
    bus = Gio.bus_get_sync(Gio.BusType.SESSION, None)
gi.repository.GLib.Error: g-io-error-quark: Cannot autolaunch D-Bus without X11 $DISPLAY (0)
Died at ./Tools/Scripts/update-webkitgtk-libs line 28.
program finished with exit code 1
Comment 8 Philippe Normand 2020-05-04 02:03:21 PDT
Broke some mac bots too:

Traceback (most recent call last):
  File "./Tools/Scripts/run-perf-tests", line 38, in <module>
    import flatpakutils
  File "./Tools/flatpak/flatpakutils.py", line 37, in <module>
    from gi.repository import Gio, GLib
ImportError: No module named gi.repository
Comment 9 Philippe Normand 2020-05-20 01:16:41 PDT
No longer necessary after bug 212077 lands.