Bug 211277 - [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path
Summary: [Flatpak SDK] Honor XDG_RUNTIME_DIR when setting the document path
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Lauro Moura
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 20:53 PDT by Lauro Moura
Modified: 2020-05-01 02:49 PDT (History)
3 users (show)

See Also:


Attachments
Patch (2.86 KB, patch)
2020-04-30 21:06 PDT, Lauro Moura
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Lauro Moura 2020-04-30 20:53:47 PDT
Currently flatpakutils.py hardcodes the path to the document portal to /run/user/$UID/doc, but in practice, it depends on the value of $XDG_RUNTIME_DIR (which typically is /run/user/$UID). Problems with this var can lead to bubblewrap (used by flatpak) to fail with messages like 'brwap: Can't find source path : No such file or directory.'
Comment 1 Lauro Moura 2020-04-30 21:06:14 PDT
Created attachment 398156 [details]
Patch

This version checks environment for XDG_RUNTIME_DIR instead of using the dbus method GetMountPoint. Currently there is no direct dbus usage from webkitpy. One issue that may still be present is the complete absence of the runtime directory. Should flatpakutils.py create a 'fake' one or this should be in charge of whoever uses webkit-flatpak? (e.g. the bots scripts).
Comment 2 EWS 2020-05-01 02:48:26 PDT
Committed r260991: <https://trac.webkit.org/changeset/260991>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398156 [details].
Comment 3 Radar WebKit Bug Importer 2020-05-01 02:49:16 PDT
<rdar://problem/62714503>