Bug 211268 - TriState should be an enum class and use "Indeterminate" instead of "Mixed"
Summary: TriState should be an enum class and use "Indeterminate" instead of "Mixed"
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 18:20 PDT by Ross Kirsling
Modified: 2020-04-30 22:39 PDT (History)
13 users (show)

See Also:


Attachments
Patch (85.60 KB, patch)
2020-04-30 19:17 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (86.20 KB, patch)
2020-04-30 19:43 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (86.17 KB, patch)
2020-04-30 19:46 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (86.83 KB, patch)
2020-04-30 20:05 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch for landing (87.63 KB, patch)
2020-04-30 20:36 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-04-30 18:20:02 PDT
TriState should be an enum class and use "Indeterminate" instead of "Mixed"
Comment 1 Ross Kirsling 2020-04-30 19:17:14 PDT
Created attachment 398142 [details]
Patch
Comment 2 Mark Lam 2020-04-30 19:38:57 PDT
Comment on attachment 398142 [details]
Patch

r=me
Comment 3 Ross Kirsling 2020-04-30 19:43:35 PDT
Created attachment 398144 [details]
Patch
Comment 4 Ross Kirsling 2020-04-30 19:45:24 PDT
(In reply to Mark Lam from comment #2)
> Comment on attachment 398142 [details]
> Patch
> 
> r=me

Oops, didn't see this! Will reupload without the r?.
Comment 5 Ross Kirsling 2020-04-30 19:46:08 PDT
Created attachment 398145 [details]
Patch for landing
Comment 6 Ross Kirsling 2020-04-30 20:05:13 PDT
Created attachment 398149 [details]
Patch for landing
Comment 7 Ross Kirsling 2020-04-30 20:36:41 PDT
Created attachment 398154 [details]
Patch for landing
Comment 8 EWS 2020-04-30 22:38:10 PDT
Committed r260984: <https://trac.webkit.org/changeset/260984>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398154 [details].
Comment 9 Radar WebKit Bug Importer 2020-04-30 22:39:14 PDT
<rdar://problem/62703576>