Bug 211250 - Inline reportBlockedPortFailed and reportAuthenticationChallengeBlocked
Summary: Inline reportBlockedPortFailed and reportAuthenticationChallengeBlocked
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: Safari Technology Preview
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Rob Buis
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 13:11 PDT by Rob Buis
Modified: 2020-04-30 23:51 PDT (History)
6 users (show)

See Also:

Attachments
Patch (5.07 KB, patch)
2020-04-30 13:13 PDT, Rob Buis 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Rob Buis 2020-04-30 13:11:32 PDT 
These two static methods have only one caller each, so we can just
inline them at the call site since there is nothing tying them to FrameLoader.
Comment 1 Rob Buis 2020-04-30 13:13:03 PDT 
Created attachment 398085 [details]
Patch
Comment 2 Rob Buis 2020-04-30 14:25:32 PDT 
Comment on attachment 398085 [details]
Patch

Note that other solutions are possible as well, like making these private methods in the caller classes, or finding a different place as free functions, I just do not see the relation to FrameLoader.
Comment 3 EWS 2020-04-30 23:50:59 PDT 
Committed r260985: <https://trac.webkit.org/changeset/260985>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398085 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-30 23:51:14 PDT 
<rdar://problem/62707204>