Result archives for layout tests can be unreasonably large, especially if there are many crashes. Failing to upload these archives should not be fatal.
Created attachment 398081 [details] Patch
Inspired by events like this: https://build.webkit.org/builders/Apple%20iOS%2013%20Simulator%20Debug%20WK2%20%28Tests%29/builds/3427/steps/layout-test/logs/stdio
Created attachment 398083 [details] Patch
Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review > Tools/Scripts/webkitpy/results/upload.py:229 > + log_line_func(' ' * 4 + 'Failed to upload test archive to {}, results server dropped connection, likely due to archive size.'.format(hostname)) Can we also print the archive size here? > Tools/Scripts/webkitpy/results/upload.py:231 > + return True What happens is server is down or unreachable? Do we still use this code path or print a different error?
Comment on attachment 398083 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=398083&action=review >> Tools/Scripts/webkitpy/results/upload.py:231 >> + return True > > What happens is server is down or unreachable? Do we still use this code path or print a different error? It does, but it’s unlikely we would ever get into that circumstance because the result upload would have also failed.
Created attachment 398150 [details] Patch
Created attachment 398185 [details] Patch
Committed r261000: <https://trac.webkit.org/changeset/261000> All reviewed patches have been landed. Closing bug and clearing flags on attachment 398185 [details].
<rdar://problem/62728138>