Bug 211240 - WebCore::systemHasBattery() is unnecessarily expensive on iOS
Summary: WebCore::systemHasBattery() is unnecessarily expensive on iOS
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 10:51 PDT by Chris Dumez
Modified: 2020-04-30 12:43 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.82 KB, patch)
2020-04-30 10:53 PDT, Chris Dumez 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-04-30 10:51:51 PDT 
WebCore::systemHasBattery() is unnecessarily expensive on iOS since iOS devices always have a battery.
Comment 1 Chris Dumez 2020-04-30 10:52:01 PDT 
<rdar://problem/62619971>
Comment 2 Chris Dumez 2020-04-30 10:53:43 PDT 
Created attachment 398066 [details]
Patch
Comment 3 Geoffrey Garen 2020-04-30 11:01:35 PDT 
Comment on attachment 398066 [details]
Patch

I look forward to finding this code ten years from now, to fix a new hardware bug. 😬
Comment 4 EWS 2020-04-30 12:43:19 PDT 
Committed r260960: <https://trac.webkit.org/changeset/260960>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398066 [details].