Bug 211238 - [iOS] Every running WebContent process should be granted access to frontboard services when Accessibility is enabled
Summary: [iOS] Every running WebContent process should be granted access to frontboard...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Per Arne Vollan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-30 09:35 PDT by Per Arne Vollan
Modified: 2020-05-01 13:30 PDT (History)
2 users (show)

See Also:

Attachments
Patch (7.58 KB, patch)
2020-04-30 10:06 PDT, Per Arne Vollan 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Per Arne Vollan 2020-04-30 09:35:35 PDT 
Currently, every WebContent process is granted access to frontboard services if Accessibility is enabled at the time of startup. However, WebContent processes running at the time when Accessibility is enabled are not granted access, which is a bug.
Comment 1 Radar WebKit Bug Importer 2020-04-30 09:35:57 PDT 
<rdar://problem/62656173>
Comment 2 Per Arne Vollan 2020-04-30 10:06:18 PDT 
Created attachment 398059 [details]
Patch
Comment 3 Daniel Bates 2020-05-01 13:02:51 PDT 
Comment on attachment 398059 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398059&action=review

Patch looks good.

> Tools/TestWebKitAPI/Tests/WebKit/EnableAccessibility.mm:87
> +    ASSERT_TRUE(sandboxAccess());

Ok as is. No change needed. Optimal patch uses EXPECT_TRUE() to future proof this code should any more asserts be added.
Comment 4 Per Arne Vollan 2020-05-01 13:06:27 PDT 
Comment on attachment 398059 [details]
Patch

Thanks for reviewing!
Comment 5 EWS 2020-05-01 13:30:25 PDT 
Committed r261016: <https://trac.webkit.org/changeset/261016>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398059 [details].