Bug 211229 – Disable low latency encoder on iOS

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Disable VCP on iOS until ready

[youenn fablet]

Created attachment 398050 [details]
Patch

[EWS]

Committed r260956: <https://trac.webkit.org/changeset/260956>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398050 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62662886>

[Darin Adler]

When possible we should try to make more careful use of HAVE vs. USE and Platform headers vs. SPI headers vs. SoftLink headers.

It’s a little peculiar to define a HAVE in an SPI header. Seems even more peculiar to have it in a SoftLink header.

Our decision here seems to be about whether to *use* something, not whether it’s present, so that sounds like USE instead of HAVE. In this situation, I might have changed the conditionals in the code to USE instead of HAVE, and turned it off that way.

And moved the HAVE to a PlatformHave header, out of the SoftLink header.

And defined USE to a PlatformUse header with a default of 0.

There may be arguments agains this such as:

- This small change is effective and low risk; doing a bigger change instead is messy and risky.

- It’s nice to concentrate information about whether the platform has something with the header for that thing, so annoying that the HAVE macro is supposed to go in one of the PlatformHave headers.

- For something that’s not ready at all yet, seems unnecessary to have it in a PlatformUse header.

But I also think it’s valuable to separate HAVE and USE, and separate configuration and platform capability information from the headers with specific classes and functions.

I suggest that when we bring this macro back we do it in the platform machinery, not by adding it back to the SoftLink header.