Bug 211213 – Ensure Intl classes don't have naming conflicts with unified builds

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Ross Kirsling]

Ensure Intl classes don't have naming conflicts with unified builds

[Ross Kirsling]

Created attachment 398012 [details]
Patch

[Yusuke Suzuki]

Comment on attachment 398012 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398012&action=review

r=me

> Source/JavaScriptCore/runtime/IntlCollator.h:60
> +    static Vector<String> sortLocaleData(const String&, size_t);
> +    static Vector<String> searchLocaleData(const String&, size_t);
> +

Let's put it behind private: if possible.

> Source/JavaScriptCore/runtime/IntlDateTimeFormat.h:57
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

> Source/JavaScriptCore/runtime/IntlNumberFormat.h:58
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

> Source/JavaScriptCore/runtime/IntlPluralRules.h:56
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

> Source/JavaScriptCore/runtime/IntlRelativeTimeFormat.h:55
> +    static Vector<String> localeData(const String&, size_t);

Ditto.

[Ross Kirsling]

Created attachment 398021 [details]
Patch for landing

[EWS]

Committed r260931: <https://trac.webkit.org/changeset/260931>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398021 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62630024>

[Darin Adler]

Comment on attachment 398021 [details]
Patch for landing

View in context: https://bugs.webkit.org/attachment.cgi?id=398021&action=review

> Source/JavaScriptCore/runtime/IntlCollator.h:71
> +    static Vector<String> sortLocaleData(const String&, size_t);
> +    static Vector<String> searchLocaleData(const String&, size_t);

Avoiding name conflict is a good thing. Adding more in headers is not such a good thing. I guess I’m OK with this, but generally would be nice to have the headers be as small as possible and not have implementation details that they don’t need to.