Bug 211210 - EWS should skip Apple Win build and tests for patches that only change WebKit2 sources
Summary: EWS should skip Apple Win build and tests for patches that only change WebKit...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Aakash Jain
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-29 15:37 PDT by David Kilzer (:ddkilzer)
Modified: 2022-01-05 17:55 PST (History)
9 users (show)

See Also:

Attachments
Patch (5.30 KB, patch)
2020-05-04 10:05 PDT, Aakash Jain 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2020-04-29 15:37:23 PDT 
EWS should skip Apple Win build and tests for patches that only change WebKit2 sources.

See also:  Bug 210115: EWS should skip mac-wk1 and mac-debug-wk1 tests for patches that only change WebKit2 sources
Comment 1 Aakash Jain 2020-05-03 05:29:01 PDT 
Is this applicable to WinCairo as well? (wincairo ews doesn't run tests, only builds)
Comment 2 Aakash Jain 2020-05-04 10:05:02 PDT 
Created attachment 398383 [details]
Patch
Comment 3 Per Arne Vollan 2020-05-04 10:36:08 PDT 
(In reply to Aakash Jain from comment #1)
> Is this applicable to WinCairo as well? (wincairo ews doesn't run tests,
> only builds)

I don't think this is applicable to WinCairo.
Comment 4 Aakash Jain 2020-05-05 06:16:21 PDT 
(In reply to Per Arne Vollan from comment #3)
> I don't think this is applicable to WinCairo.
ok. the attached patch is only for Apple Windows platform.
Comment 5 EWS 2020-05-05 11:34:25 PDT 
Committed r261184: <https://trac.webkit.org/changeset/261184>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398383 [details].
Comment 6 Radar WebKit Bug Importer 2020-05-05 11:35:14 PDT 
<rdar://problem/62896445>
Comment 7 Aakash Jain 2020-05-07 08:31:23 PDT 
Deployed on server yesterday. Seems to be working fine. e.g.:
https://ews-build.webkit.org/#/builders/10/builds/17575
https://ews-build.webkit.org/#/builders/10/builds/17563
Comment 8 Fujii Hironori 2022-01-05 17:55:32 PST 
Comment on attachment 398383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398383&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:307
> +        'windows': wk1_paths,

This code has a problem.
Filed: Bug 234911 – AppleWin EWS check-patch-relevance skips a patch for Source/cmake/*.cmake