Bug 211210 – EWS should skip Apple Win build and tests for patches that only change WebKit2 sources

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[David Kilzer (:ddkilzer)]

EWS should skip Apple Win build and tests for patches that only change WebKit2 sources.

See also:  Bug 210115: EWS should skip mac-wk1 and mac-debug-wk1 tests for patches that only change WebKit2 sources

[Aakash Jain]

Is this applicable to WinCairo as well? (wincairo ews doesn't run tests, only builds)

[Aakash Jain]

Created attachment 398383 [details]
Patch

[Per Arne Vollan]

(In reply to Aakash Jain from comment #1)
> Is this applicable to WinCairo as well? (wincairo ews doesn't run tests,
> only builds)

I don't think this is applicable to WinCairo.

[Aakash Jain]

(In reply to Per Arne Vollan from comment #3)
> I don't think this is applicable to WinCairo.
ok. the attached patch is only for Apple Windows platform.

[EWS]

Committed r261184: <https://trac.webkit.org/changeset/261184>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398383 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62896445>

[Aakash Jain]

Deployed on server yesterday. Seems to be working fine. e.g.:
https://ews-build.webkit.org/#/builders/10/builds/17575
https://ews-build.webkit.org/#/builders/10/builds/17563

[Fujii Hironori]

Comment on attachment 398383 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398383&action=review

> Tools/BuildSlaveSupport/ews-build/steps.py:307
> +        'windows': wk1_paths,

This code has a problem.
Filed: Bug 234911 – AppleWin EWS check-patch-relevance skips a patch for Source/cmake/*.cmake