WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
211208
make_names.pl should accept another file which just generates misc names additionally
https://bugs.webkit.org/show_bug.cgi?id=211208
Summary
make_names.pl should accept another file which just generates misc names addi...
Yusuke Suzuki
Reported
2020-04-29 14:40:59 PDT
There are so many adhoc `static NeverDestroyed<const AtomString> ...` things in WebCore code and sometimes we are doing `AtomString { ..., AtomString::CreateFromLiteral }` in a critical path.
Attachments
Add attachment
proposed patch, testcase, etc.
Yusuke Suzuki
Comment 1
2020-04-29 22:52:36 PDT
After considering about this, I'm currently not sure whether this is better. Since NeverDestroyed<AtomString> can lazily initialize it, (maybe does not matter much).
Yusuke Suzuki
Comment 2
2020-04-29 22:54:24 PDT
I have a patch for this, but I'll first do a simpler one, use NeverDestroyed<AtomString> instead of constructing AtomString every time.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug