Bug 211202 - [iOS][WK2] Add timeout for "Client navigation" foreground assertion
Summary: [iOS][WK2] Add timeout for "Client navigation" foreground assertion
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Chris Dumez
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-29 13:31 PDT by Chris Dumez
Modified: 2020-04-30 14:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (10.60 KB, patch)
2020-04-29 13:33 PDT, Chris Dumez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Chris Dumez 2020-04-29 13:31:36 PDT
Add timeout for "Client navigation" foreground assertion. Foreground assertions do not timeout at RunningBoard level and we thus need to make sure we release them to avoid power leaks.
Comment 1 Chris Dumez 2020-04-29 13:33:45 PDT
Created attachment 397993 [details]
Patch
Comment 2 Alex Christensen 2020-04-30 13:12:47 PDT
Comment on attachment 397993 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397993&action=review

> Source/WebKit/UIProcess/API/APINavigation.cpp:70
> +    , m_clientNavigationActivity(navigationActivityTimeout)

I feel like this kind of initialization can be done with an initializer list in the header.
Comment 3 EWS 2020-04-30 14:19:19 PDT
Committed r260966: <https://trac.webkit.org/changeset/260966>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397993 [details].
Comment 4 Radar WebKit Bug Importer 2020-04-30 14:20:14 PDT
<rdar://problem/62673956>