Bug 211189 – [GTK4][X11] Add support for rendering web view contents

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

.

[Carlos Garcia Campos]

Created attachment 397970 [details]
Patch

[Adrian Perez]

Comment on attachment 397970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397970&action=review

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:37
> +#define WK_XVISUAL(platformDisplay) (static_cast<Visual*>(platformDisplay.visual()))

/me sighs at X11 (╥_╥)

> Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:205
> +    auto* visual = WK_XVISUAL(downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()));

Maybe we want to always use the WK_XVISUAL() variant and remove the #if here?
I doubt that GTK would choose one different from what PlatformDisplayX11::visual()
finds.

[Carlos Garcia Campos]

(In reply to Adrian Perez from comment #2)
> Comment on attachment 397970 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397970&action=review
> 
> > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:37
> > +#define WK_XVISUAL(platformDisplay) (static_cast<Visual*>(platformDisplay.visual()))
> 
> /me sighs at X11 (╥_╥)
> 
> > Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:205
> > +    auto* visual = WK_XVISUAL(downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()));
> 
> Maybe we want to always use the WK_XVISUAL() variant and remove the #if here?
> I doubt that GTK would choose one different from what
> PlatformDisplayX11::visual()
> finds.

I prefer not to change the GTK3 behavior, even less in X11 related code that I don't test myself.

[Carlos Garcia Campos]

Committed r260946: <https://trac.webkit.org/changeset/260946>