Bug 211189 - [GTK4][X11] Add support for rendering web view contents
Summary: [GTK4][X11] Add support for rendering web view contents
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: GTK4
  Show dependency tree / graph
 
Reported: 2020-04-29 09:40 PDT by Carlos Garcia Campos
Modified: 2020-04-30 05:59 PDT (History)
2 users (show)

See Also:

Attachments
Patch (14.17 KB, patch)
2020-04-29 09:46 PDT, Carlos Garcia Campos 		aperez: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2020-04-29 09:40:23 PDT 
.
Comment 1 Carlos Garcia Campos 2020-04-29 09:46:36 PDT 
Created attachment 397970 [details]
Patch
Comment 2 Adrian Perez 2020-04-30 05:53:05 PDT 
Comment on attachment 397970 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397970&action=review

> Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:37
> +#define WK_XVISUAL(platformDisplay) (static_cast<Visual*>(platformDisplay.visual()))

/me sighs at X11 (╥_╥)

> Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:205
> +    auto* visual = WK_XVISUAL(downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()));

Maybe we want to always use the WK_XVISUAL() variant and remove the #if here?
I doubt that GTK would choose one different from what PlatformDisplayX11::visual()
finds.
Comment 3 Carlos Garcia Campos 2020-04-30 05:57:50 PDT 
(In reply to Adrian Perez from comment #2)
> Comment on attachment 397970 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397970&action=review
> 
> > Source/WebCore/platform/graphics/x11/PlatformDisplayX11.h:37
> > +#define WK_XVISUAL(platformDisplay) (static_cast<Visual*>(platformDisplay.visual()))
> 
> /me sighs at X11 (╥_╥)
> 
> > Source/WebKit/UIProcess/gtk/AcceleratedBackingStoreX11.cpp:205
> > +    auto* visual = WK_XVISUAL(downcast<PlatformDisplayX11>(PlatformDisplay::sharedDisplay()));
> 
> Maybe we want to always use the WK_XVISUAL() variant and remove the #if here?
> I doubt that GTK would choose one different from what
> PlatformDisplayX11::visual()
> finds.

I prefer not to change the GTK3 behavior, even less in X11 related code that I don't test myself.
Comment 4 Carlos Garcia Campos 2020-04-30 05:59:00 PDT 
Committed r260946: <https://trac.webkit.org/changeset/260946>