Bug 211186 – [GTK4] Bring back the URI entry to MiniBrowser

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Claudio Saavedra]

[GTK4] Bring back the URI entry to MiniBrowser

[Claudio Saavedra]

Created attachment 397965 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 397965 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397965&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:523
> +        GBytes *bytes = g_bytes_new_static(cairo_image_surface_get_data(surface), stride*height);

stride*height -> stride * height

I'm afraid we need to copy the data here, the favicon is owned by the web view and will be deleted on navigation.

[Claudio Saavedra]

Created attachment 398047 [details]
Patch

[Carlos Garcia Campos]

Comment on attachment 398047 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=398047&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:117
> +#if GTK_CHECK_VERSION(3, 98, 0)
> +                            gtk_editable_get_text(GTK_EDITABLE(window->uriEntry))
> +#else
> +                            gtk_entry_get_text(GTK_ENTRY(window->uriEntry))
> +#endif

Indentation is wrong here.

[Claudio Saavedra]

Created attachment 398048 [details]
Patch for landing

[EWS]

Committed r260942: <https://trac.webkit.org/changeset/260942>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 398048 [details].