[JSC] Align upon the name isCallable instead of isFunction
Created attachment 397868 [details] Patch
Created attachment 397870 [details] Patch
Comment on attachment 397870 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397870&action=review r=me assuming the EWS confirms this compiles everywhere > Source/JavaScriptCore/runtime/JSCJSValueInlines.h:894 > if (!isCell()) > return false; > - return asCell()->isFunction(vm); > + return asCell()->isCallable(vm); I really like && for functions like this: return isCell() && asCell()->isCallable(vm); Obviously that has nothing to do with this patch.
Created attachment 397885 [details] Patch for landing
Committed r260848: <https://trac.webkit.org/changeset/260848> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397885 [details].
<rdar://problem/62548189>
Comment on attachment 397885 [details] Patch for landing View in context: https://bugs.webkit.org/attachment.cgi?id=397885&action=review > Source/JavaScriptCore/ftl/FTLLowerDFGToB3.cpp:17902 > + LValue isCallable(LValue cell, SpeculatedType type = SpecFullTop) This is wrong, this one really is "isFunction". You could rename this to "isJSFunction" or keep it as "isFunction"
Committed r260919: <https://trac.webkit.org/changeset/260919>