Bug 211138 – Make PolicyChecker an inner class of FrameLoader

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Rob Buis]

PolicyChecker HistoryController an inner class of FrameLoader, this allows us to move some methods
only used by PolicyChecker out of the FrameLoader public API. Because it is not possible to forward declare
an enum class in an inner class, move ShouldContinue out of the PolicyChecker class and rename it
to ShouldContinuePolicyCheck.

[Rob Buis]

Created attachment 397865 [details]
Patch

[Rob Buis]

Created attachment 397882 [details]
Patch

[Rob Buis]

Created attachment 397883 [details]
Patch

[Alex Christensen]

Comment on attachment 397883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397883&action=review

> Source/WebCore/loader/FrameLoader.h:112
>      PolicyChecker& policyChecker() const { return *m_policyChecker; }

You could make m_policyChecker a UniqueRef

> Source/WebCore/loader/FrameLoaderTypes.h:115
> +enum class ShouldContinuePolicyCheck : uint8_t {

bool

> Source/WebCore/loader/PolicyChecker.h:114
> +template<> struct EnumTraits<WebCore::ShouldContinuePolicyCheck> {

This is not needed if ShouldContinuePolicyCheck has a bool underlying type.

[Rob Buis]

Created attachment 397940 [details]
Patch

[EWS]

Committed r260890: <https://trac.webkit.org/changeset/260890>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397940 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62587616>

[Rob Buis]

Comment on attachment 397883 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397883&action=review

>> Source/WebCore/loader/FrameLoader.h:112
>>      PolicyChecker& policyChecker() const { return *m_policyChecker; }
> 
> You could make m_policyChecker a UniqueRef

Is there a clear benefit? I left it out for landing since there are a few similar cases in FrameLoader, I think it is better if needed to fix them all in one patch if there are benefits.

>> Source/WebCore/loader/FrameLoaderTypes.h:115
>> +enum class ShouldContinuePolicyCheck : uint8_t {
> 
> bool

Done.

>> Source/WebCore/loader/PolicyChecker.h:114
>> +template<> struct EnumTraits<WebCore::ShouldContinuePolicyCheck> {
> 
> This is not needed if ShouldContinuePolicyCheck has a bool underlying type.

Nice! I removed it.