Bug 211136 - Move WebPage::textInputContextsInRect() to WebPageIOS.mm
Summary: Move WebPage::textInputContextsInRect() to WebPageIOS.mm
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-28 11:31 PDT by Daniel Bates
Modified: 2020-04-28 17:11 PDT (History)
3 users (show)

See Also:

Attachments
Patch (6.52 KB, patch)
2020-04-28 11:53 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (9.88 KB, patch)
2020-04-28 16:31 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Patch (9.88 KB, patch)
2020-04-28 16:31 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
To Land (9.90 KB, patch)
2020-04-28 17:05 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (3) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-28 11:31:46 PDT 
WebPage::textInputContextsInRect() is only used on iOS at the moment and likely is not relevant to any other port. So, move it to WebPageIOS.mm.
Comment 1 Daniel Bates 2020-04-28 11:53:24 PDT 
Created attachment 397862 [details]
Patch
Comment 2 Daniel Bates 2020-04-28 11:54:44 PDT 
I wrote this patch on top of the patch for bug #211135. So, it won't apply until that one lands.
Comment 3 Daniel Bates 2020-04-28 16:31:08 PDT 
Created attachment 397898 [details]
Patch
Comment 4 Daniel Bates 2020-04-28 16:31:50 PDT 
Created attachment 397899 [details]
Patch
Comment 5 Daniel Bates 2020-04-28 17:01:48 PDT 
Comment on attachment 397899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397899&action=review

> Source/WebKit/ChangeLog:18
> +        I side effect of this change is that I also move WebPageProxy::textInputContextsInRect()

I => A
Comment 6 Eric Carlson 2020-04-28 17:02:42 PDT 
Comment on attachment 397899 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397899&action=review

> Source/WebKit/ChangeLog:18
> +        I side effect of this change is that I also move WebPageProxy::textInputContextsInRect()

s/I side effect/A side effect/ (or do you mean "One side effect"?)
Comment 7 Daniel Bates 2020-04-28 17:05:42 PDT 
Created attachment 397909 [details]
To Land
Comment 8 Daniel Bates 2020-04-28 17:06:04 PDT 
Committed r260857: <https://trac.webkit.org/changeset/260857>
Comment 9 Radar WebKit Bug Importer 2020-04-28 17:11:11 PDT 
<rdar://problem/62558562>