Bug 21113 - r36771 caused www.nytimes.com to not display when you return to it using back/forward
Summary: r36771 caused www.nytimes.com to not display when you return to it using back...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL: http://www.nytimes.com
Keywords:
: 21119 21125 (view as bug list)
Depends on:
Blocks:
 
Reported: 2008-09-25 11:41 PDT by Brady Eidson
Modified: 2008-09-25 18:22 PDT (History)
3 users (show)

See Also:


Attachments
Patch #2 (5.19 KB, patch)
2008-09-25 12:58 PDT, Dave Hyatt
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2008-09-25 11:41:12 PDT
r36771 caused www.nytimes.com to not display when you return to it using back/forward.

Since this was primarily a "cleanup patch", I rolled it out in r36902 as this was a pretty severe regression (important site).  

Steps to reproduce with 36771 in place:

1 - Visit www.google.com, let it finish loading
2 - Visit www.nytimes.com, let it finish loading
3 - Click "back" to return to google.com
4 - Click "forward" to return to nytimes.com

After step 4, nytimes.com is blank.  All of the resources are there and loaded, and Cmd-R to forcefully refresh the page causes it to actually render, but whenever you return to it through back or forward, it is always blank.
Comment 1 Dave Hyatt 2008-09-25 12:58:57 PDT
Created attachment 23817 [details]
Patch #2
Comment 2 Darin Adler 2008-09-25 13:10:01 PDT
Comment on attachment 23817 [details]
Patch #2

 CSSRule* CSSRule::parentRule() const
 {
-    // FIXME: I believe this always returns 0.
-    // A correct implementation would have to look farther up than just the parent.
     return (parent() && parent()->isRule()) ? static_cast<CSSRule*>(parent()) : 0;
 }

Why is this comment wrong. Isn't the parent almost always a style sheet, and not a rule?

r=me
Comment 3 Dave Hyatt 2008-09-25 13:16:17 PDT
Fixed in r36904.

Comment 4 Dave Hyatt 2008-09-25 14:11:22 PDT
*** Bug 21119 has been marked as a duplicate of this bug. ***
Comment 5 Matt Lilek 2008-09-25 18:22:26 PDT
*** Bug 21125 has been marked as a duplicate of this bug. ***