Bug 211109 – Web Inspector: Debug: "Outline focused element" should also outline elements with tabIndex=0

• Status: RESOLVED
• Resolution: FIXED
• Component: Web Inspector

[Nikita Vasilyev]

Created attachment 397775 [details]
[Image] With patch applied

Outlining elements with tabIndex=0 helps me to see what's tabbable and what isn't.
It saves me time tabbing back and forth between elements.

[Nikita Vasilyev]

Created attachment 397776 [details]
Patch

[Devin Rousso]

Comment on attachment 397776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397776&action=review

r=me

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26
> +body.focus-debug [tabindex="0"] {

Would it be worth having additional colors for `[tabindex="-1"]` and `[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well?

[Nikita Vasilyev]

Comment on attachment 397776 [details]
Patch

(In reply to Devin Rousso from comment #2)
> Comment on attachment 397776 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397776&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26
> > +body.focus-debug [tabindex="0"] {
> 
> Would it be worth having additional colors for `[tabindex="-1"]` and
> `[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well?

I didn't find that particularly useful, personally.

[EWS]

Committed r260853: <https://trac.webkit.org/changeset/260853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397776 [details].

[Radar WebKit Bug Importer]

<rdar://problem/62553349>