Bug 211109 - Web Inspector: Debug: "Outline focused element" should also outline elements with tabIndex=0
Summary: Web Inspector: Debug: "Outline focused element" should also outline elements ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: WebKit Nightly Build
Hardware: All All
: P2 Normal
Assignee: Nikita Vasilyev
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-27 18:00 PDT by Nikita Vasilyev
Modified: 2020-04-28 15:58 PDT (History)
3 users (show)

See Also:


Attachments
[Image] With patch applied (302.86 KB, image/png)
2020-04-27 18:00 PDT, Nikita Vasilyev
no flags Details
Patch (1.36 KB, patch)
2020-04-27 18:01 PDT, Nikita Vasilyev
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Nikita Vasilyev 2020-04-27 18:00:01 PDT
Created attachment 397775 [details]
[Image] With patch applied

Outlining elements with tabIndex=0 helps me to see what's tabbable and what isn't.
It saves me time tabbing back and forth between elements.
Comment 1 Nikita Vasilyev 2020-04-27 18:01:57 PDT
Created attachment 397776 [details]
Patch
Comment 2 Devin Rousso 2020-04-28 12:11:32 PDT
Comment on attachment 397776 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397776&action=review

r=me

> Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26
> +body.focus-debug [tabindex="0"] {

Would it be worth having additional colors for `[tabindex="-1"]` and `[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well?
Comment 3 Nikita Vasilyev 2020-04-28 15:36:34 PDT
Comment on attachment 397776 [details]
Patch

(In reply to Devin Rousso from comment #2)
> Comment on attachment 397776 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=397776&action=review
> 
> r=me
> 
> > Source/WebInspectorUI/UserInterface/Debug/Bootstrap.css:26
> > +body.focus-debug [tabindex="0"] {
> 
> Would it be worth having additional colors for `[tabindex="-1"]` and
> `[tabindex]:not([tabindex="-1"], [tabindex="0"])` as well?

I didn't find that particularly useful, personally.
Comment 4 EWS 2020-04-28 15:57:31 PDT
Committed r260853: <https://trac.webkit.org/changeset/260853>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397776 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-28 15:58:16 PDT
<rdar://problem/62553349>