RESOLVED FIXED 211094
results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing 
https://bugs.webkit.org/show_bug.cgi?id=211094
Summary results.webkit.org: A suite running multiple times in a commit for a single c...
Jonathan Bedard
Reported 2020-04-27 14:50:25 PDT
This is a difficult issue to catch because it causes a race condition. If we manage to pick up the processing task before the next run reports, everything works as expected. If we report too quickly, though, we over-write the redis key of the first run.
Attachments
Patch (1.69 KB, patch)
2020-04-27 14:58 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.77 KB, patch)
2020-04-27 16:10 PDT, Jonathan Bedard 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2020-04-27 14:56:49 PDT
<rdar://problem/62470170>
Jonathan Bedard
Comment 2 2020-04-27 14:58:39 PDT
Created attachment 397746 [details] Patch
Aakash Jain
Comment 3 2020-04-27 15:02:57 PDT
Comment on attachment 397746 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=397746&action=review > Tools/resultsdbpy/resultsdbpy/model/upload_context.py:195 > + hash_key = hash(configuration) ^ hash(branch) ^ hash(self.commit_context.uuid_for_commits(commits)) ^ hash(suite) ^ hash(timestamp) Bug description or Changelog can be made more descriptive explaining that the hash key was colliding in certain cases.
Jonathan Bedard
Comment 4 2020-04-27 16:10:28 PDT
Created attachment 397759 [details] Patch for landing
EWS
Comment 5 2020-04-27 16:32:42 PDT
Committed r260796: <https://trac.webkit.org/changeset/260796> All reviewed patches have been landed. Closing bug and clearing flags on attachment 397759 [details].
Note You need to log in before you can comment on or make changes to this bug.