Bug 211094 - results.webkit.org: A suite running multiple times in a commit for a single configuration may pre-empt processing
Summary: results.webkit.org: A suite running multiple times in a commit for a single c...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Jonathan Bedard
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-27 14:50 PDT by Jonathan Bedard
Modified: 2020-04-27 16:43 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.69 KB, patch)
2020-04-27 14:58 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff
Patch for landing (1.77 KB, patch)
2020-04-27 16:10 PDT, Jonathan Bedard
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jonathan Bedard 2020-04-27 14:50:25 PDT
This is a difficult issue to catch because it causes a race condition. If we manage to pick up the processing task before the next run reports, everything works as expected. If we report too quickly, though, we over-write the redis key of the first run.
Comment 1 Radar WebKit Bug Importer 2020-04-27 14:56:49 PDT
<rdar://problem/62470170>
Comment 2 Jonathan Bedard 2020-04-27 14:58:39 PDT
Created attachment 397746 [details]
Patch
Comment 3 Aakash Jain 2020-04-27 15:02:57 PDT
Comment on attachment 397746 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397746&action=review

> Tools/resultsdbpy/resultsdbpy/model/upload_context.py:195
> +            hash_key = hash(configuration) ^ hash(branch) ^ hash(self.commit_context.uuid_for_commits(commits)) ^ hash(suite) ^ hash(timestamp)

Bug description or Changelog can be made more descriptive explaining that the hash key was colliding in certain cases.
Comment 4 Jonathan Bedard 2020-04-27 16:10:28 PDT
Created attachment 397759 [details]
Patch for landing
Comment 5 EWS 2020-04-27 16:32:42 PDT
Committed r260796: <https://trac.webkit.org/changeset/260796>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397759 [details].