Bug 21109 - Console should right-align urls
Summary: Console should right-align urls
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (Deprecated) (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.5
: P2 Normal
Assignee: Kevin McCullough
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2008-09-25 10:13 PDT by Kevin McCullough
Modified: 2008-09-25 13:30 PDT (History)
0 users

See Also:


Attachments
Proposed patch (872 bytes, patch)
2008-09-25 10:14 PDT, Kevin McCullough
no flags Details | Formatted Diff | Diff
Image of what right-align looks like (19.25 KB, image/png)
2008-09-25 10:19 PDT, Kevin McCullough
no flags Details
and what it looks like docked (20.28 KB, image/png)
2008-09-25 10:19 PDT, Kevin McCullough
no flags Details
docked without arrow (21.02 KB, image/png)
2008-09-25 10:22 PDT, Kevin McCullough
no flags Details
no arrow 1/2 padding (16.68 KB, image/png)
2008-09-25 10:26 PDT, Kevin McCullough
no flags Details
no arrow 10px padding (18.49 KB, image/png)
2008-09-25 10:28 PDT, Kevin McCullough
no flags Details
Proposed patch (1.57 KB, patch)
2008-09-25 10:32 PDT, Kevin McCullough
no flags Details | Formatted Diff | Diff
Proposed patch (3.55 KB, patch)
2008-09-25 11:31 PDT, Kevin McCullough
timothy: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin McCullough 2008-09-25 10:13:19 PDT
* SUMMARY
In the console if a JS error or JS log occurs the furthest right part of the message is a link to the resource with the error (often with the line number).  It would be nice if those were right-alinged (like Firebug) so they could be more easily seen.

<rdar://problem/6126184>
Comment 1 Kevin McCullough 2008-09-25 10:14:44 PDT
Created attachment 23802 [details]
Proposed patch
Comment 2 Kevin McCullough 2008-09-25 10:19:10 PDT
Created attachment 23803 [details]
Image of what right-align looks like
Comment 3 Kevin McCullough 2008-09-25 10:19:53 PDT
Created attachment 23804 [details]
and what it looks like docked
Comment 4 Kevin McCullough 2008-09-25 10:22:26 PDT
Created attachment 23805 [details]
docked without arrow
Comment 5 Kevin McCullough 2008-09-25 10:26:28 PDT
Created attachment 23806 [details]
no arrow 1/2 padding
Comment 6 Kevin McCullough 2008-09-25 10:28:45 PDT
Created attachment 23807 [details]
no arrow 10px padding
Comment 7 Kevin McCullough 2008-09-25 10:32:14 PDT
Created attachment 23808 [details]
Proposed patch
Comment 8 Kevin McCullough 2008-09-25 10:34:52 PDT
I need to change the DOM order.  If a message wraps the url ends up on the same line as the next message.
Comment 9 Kevin McCullough 2008-09-25 11:31:49 PDT
Created attachment 23810 [details]
Proposed patch
Comment 10 Kevin McCullough 2008-09-25 13:30:11 PDT
Committed revision 36905.