Bug 211082 - Rename CSSAnimationController accessors from animation() to legacyAnimation()
Summary: Rename CSSAnimationController accessors from animation() to legacyAnimation()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Animations (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Antoine Quint
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-27 09:48 PDT by Antoine Quint
Modified: 2020-05-10 02:00 PDT (History)
18 users (show)

See Also:

Attachments
Patch (32.01 KB, patch)
2020-04-27 09:50 PDT, Antoine Quint 		no flags Details | Formatted Diff | Diff
Patch (34.90 KB, patch)
2020-04-27 10:32 PDT, Antoine Quint 		darin: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antoine Quint 2020-04-27 09:48:14 PDT 
Rename CSSAnimationController accessors from animation() to legacyAnimation()
Comment 1 Antoine Quint 2020-04-27 09:50:24 PDT 
Created attachment 397692 [details]
Patch
Comment 2 Antoine Quint 2020-04-27 10:32:24 PDT 
Created attachment 397697 [details]
Patch
Comment 3 Antoine Quint 2020-04-27 13:47:26 PDT 
Committed r260774: <https://trac.webkit.org/changeset/260774>
Comment 4 Radar WebKit Bug Importer 2020-04-27 13:48:18 PDT 
<rdar://problem/62467071>
Comment 5 Darin Adler 2020-05-09 16:55:16 PDT 
Comment on attachment 397697 [details]
Patch

Will we ever be deleting this, or will it be around indefinitely with the name "legacyAnimation"?
Comment 6 Antoine Quint 2020-05-10 02:00:34 PDT 
(In reply to Darin Adler from comment #5)
> Comment on attachment 397697 [details]
> Patch
> 
> Will we ever be deleting this, or will it be around indefinitely with the
> name "legacyAnimation"?

We will absolutely be deleting this at the first opportunity. We are only keeping this code around for the ability to A/B test regressions on ToT for a while longer, but this is a few months at best.

I am eagerly awaiting the opportunity to rip out CSSAnimationController and all related code.