Bug 211073 – [GTK4] Add support for motion events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKitGTK

[Carlos Garcia Campos]

enter, leave and motion

[Carlos Garcia Campos]

Created attachment 397675 [details]
Patch

[Adrian Perez]

Comment on attachment 397675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397675&action=review

> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1136
> +    // FIXME: Forward event to dialog.

Wouldn't this be “if (priv->dialog) return GDK_EVENT_PROPAGATE;” like
in the function right above? If so, I think we should do it already for
this patch and remove this FIXME.

> Tools/MiniBrowser/gtk/BrowserTab.c:410
> +#if !GTK_CHECK_VERSION(3, 98, 0)

How about removing the margin also for GTK3 so we don't need the #if here?

[Carlos Garcia Campos]

Comment on attachment 397675 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=397675&action=review

>> Source/WebKit/UIProcess/API/gtk/WebKitWebViewBase.cpp:1136
>> +    // FIXME: Forward event to dialog.
> 
> Wouldn't this be “if (priv->dialog) return GDK_EVENT_PROPAGATE;” like
> in the function right above? If so, I think we should do it already for
> this patch and remove this FIXME.

No, in the case of motion events we are not just returning propagate but chaining up. I don't remember why, so I prefer to wait until we implement the dialogs to see what we need to do here.

>> Tools/MiniBrowser/gtk/BrowserTab.c:410
>> +#if !GTK_CHECK_VERSION(3, 98, 0)
> 
> How about removing the margin also for GTK3 so we don't need the #if here?

Or adding it in the case of GTK4, but I don't know how or whether it's possible. This bug is not about this, that's why I didn't change any behavior here, I added back the overlay just to avoid runtime criticals and check that items are properly hovered.

[Carlos Garcia Campos]

Created attachment 397829 [details]
Patch for landing

[EWS Watchlist]

Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API

[Carlos Garcia Campos]

Committed r260819: <https://trac.webkit.org/changeset/260819>