Bug 211056 - Text interaction tests should ensure view is not scroll instead of looking for a zoom change
Summary: Text interaction tests should ensure view is not scroll instead of looking fo...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Local Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Daniel Bates
Keywords: InRadar
Depends on:
Reported: 2020-04-26 16:06 PDT by Daniel Bates
Modified: 2020-04-27 08:45 PDT (History)
2 users (show)

See Also:

Patch (14.51 KB, patch)
2020-04-26 16:23 PDT, Daniel Bates
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2020-04-26 16:06:42 PDT
Currently the text interaction tests in RequestTextInputContext.mm look for a zoom scale change as an indirect way to know whether or not the web view zoomed to reveal the focused element. However the way the tests do so by changing the zoom scale without ensuring the editable element is still semi-occluded is racy. It works out so long as the call to focus the editable element (aka -focusTextInputContext) is processed by the web process BEFORE it receives a visible content rect update (as a result of the zoomScale change). Instead write these tests to check if the scroll view actually scrolled or not.
Comment 1 Daniel Bates 2020-04-26 16:23:58 PDT
Created attachment 397632 [details]
Comment 2 Daniel Bates 2020-04-27 08:44:29 PDT
Comment on attachment 397632 [details]

Clearing flags on attachment: 397632

Committed r260756: <https://trac.webkit.org/changeset/260756>
Comment 3 Daniel Bates 2020-04-27 08:44:31 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Radar WebKit Bug Importer 2020-04-27 08:45:18 PDT