Bug 211053 - [JSC] Clearly distinguish isConstructor from getConstructData
Summary: [JSC] Clearly distinguish isConstructor from getConstructData
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ross Kirsling
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-26 14:01 PDT by Ross Kirsling
Modified: 2020-04-26 19:41 PDT (History)
11 users (show)

See Also:


Attachments
Patch (6.98 KB, patch)
2020-04-26 14:05 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff
Patch (6.98 KB, patch)
2020-04-26 14:15 PDT, Ross Kirsling
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Kirsling 2020-04-26 14:01:05 PDT
[JSC] Clearly distinguish isConstructor from getConstructData
Comment 1 Ross Kirsling 2020-04-26 14:05:48 PDT
Created attachment 397629 [details]
Patch
Comment 2 Ross Kirsling 2020-04-26 14:11:01 PDT
I suppose with the usages clearly distinguished, Darin's suggestion of merging CallType/ConstructType into CallData/ConstructData would be a reasonable further improvement.

I can do this in a third patch if others like the idea too.
Comment 3 Ross Kirsling 2020-04-26 14:15:07 PDT
Created attachment 397630 [details]
Patch
Comment 4 EWS 2020-04-26 17:37:19 PDT
Committed r260735: <https://trac.webkit.org/changeset/260735>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397630 [details].
Comment 5 Radar WebKit Bug Importer 2020-04-26 17:38:14 PDT
<rdar://problem/62415782>