Bug 211048 - [Cocoa] stop using out arguments for document attributes when converting to attributed strings
Summary: [Cocoa] stop using out arguments for document attributes when converting to a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: HTML Editing (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-26 11:19 PDT by Darin Adler
Modified: 2020-04-27 14:35 PDT (History)
14 users (show)

See Also:

Attachments
Patch (75.41 KB, patch)
2020-04-26 11:36 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Patch (75.78 KB, patch)
2020-04-26 12:27 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2020-04-26 11:19:26 PDT 
[Cocoa] stop using out arguments for document attributes when converting to attributed strings
Comment 1 Darin Adler 2020-04-26 11:36:03 PDT 
Created attachment 397623 [details]
Patch
Comment 2 Darin Adler 2020-04-26 11:36:56 PDT 
Started this in response to Sam’s review comment in bug 210396.
Comment 3 Darin Adler 2020-04-26 12:27:35 PDT 
Created attachment 397626 [details]
Patch
Comment 4 Sam Weinig 2020-04-26 18:08:42 PDT 
Comment on attachment 397626 [details]
Patch

!!
Comment 5 EWS 2020-04-26 22:13:00 PDT 
Committed r260739: <https://trac.webkit.org/changeset/260739>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 397626 [details].
Comment 6 Radar WebKit Bug Importer 2020-04-26 22:13:17 PDT 
<rdar://problem/62426218>
Comment 7 Brent Fulgham 2020-04-27 10:48:34 PDT 
I believe this change is incomplete for MacCatalyst builds. See UIProcess/Cocoa/TextCheckingController.mm.
Comment 8 Darin Adler 2020-04-27 10:56:18 PDT 
(In reply to Brent Fulgham from comment #7)
> I believe this change is incomplete for MacCatalyst builds. See
> UIProcess/Cocoa/TextCheckingController.mm.

Tried to fix this in r260766
Comment 9 Brent Fulgham 2020-04-27 11:17:29 PDT 
That was almost perfect! I had to add a couple of #include's because of the vagaries of UnifiedSources.

Committed r260768: <https://trac.webkit.org/changeset/260768>
Comment 10 Ryan Haddad 2020-04-27 14:35:23 PDT 
(In reply to EWS from comment #5)
> Committed r260739: <https://trac.webkit.org/changeset/260739>
Catalina Perf tests started failing due to some unexpected logging after this change: https://build.webkit.org/builders/Apple-Catalina-Release-WK2-Perf/builds/783

Partial revert (as suggested by Darin) in https://trac.webkit.org/changeset/260785/webkit