Bug 211035 - [GTK] Gardening, temporarily skip WebInspector tests after r260672 and r260696
Summary: [GTK] Gardening, temporarily skip WebInspector tests after r260672 and r260696
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Diego Pino
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2020-04-25 16:54 PDT by Diego Pino
Modified: 2020-05-08 02:14 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.51 KB, patch)
2020-04-25 16:54 PDT, Diego Pino
no flags Details | Formatted Diff | Diff
Patch (2.51 KB, patch)
2020-04-25 16:56 PDT, Diego Pino
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Diego Pino 2020-04-25 16:54:15 PDT
[GTK] Gardening, temporarily skip WebInspector tests after r210942 and r260696
Comment 1 Diego Pino 2020-04-25 16:54:51 PDT
Created attachment 397598 [details]
Patch
Comment 2 Diego Pino 2020-04-25 16:56:01 PDT
Created attachment 397599 [details]
Patch
Comment 3 Diego Pino 2020-04-25 17:13:39 PDT
Committed r260713: <https://trac.webkit.org/changeset/260713>
Comment 4 Radar WebKit Bug Importer 2020-04-25 17:14:12 PDT
<rdar://problem/62377877>
Comment 5 Diego Pino 2020-04-25 17:17:56 PDT
See: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/13485/steps/layout-test/logs/stdio

Regressions: Unexpected timeouts (49)
  fast/dom/frame-loading-via-document-write.html [ Timeout ]
  fast/dom/set-document-location-host-to-unaccepted-values.html [ Timeout ]
  fast/mediastream/play-newly-added-audio-track.html [ Timeout ]
  http/tests/inspector/dom/cross-domain-inspected-node-access.html [ Timeout ]
  http/tests/inspector/dom/didFireEvent.html [ Timeout ]
  http/tests/inspector/dom/disconnect-dom-tree-after-main-frame-navigation.html [ Timeout ]
  http/tests/inspector/network/beacon-type.html [ Timeout ]
  http/tests/inspector/network/contentextensions/blocked-websocket-crash.html [ Timeout ]
  http/tests/inspector/network/copy-as-curl.html [ Timeout ]
  http/tests/inspector/network/fetch-network-data.html [ Timeout ]
  http/tests/inspector/network/fetch-response-body.html [ Timeout ]
  http/tests/inspector/network/har/har-basic.html [ Timeout ]
  http/tests/inspector/network/har/har-import.html [ Timeout ]
  http/tests/inspector/network/har/har-page-aggressive-gc.html [ Timeout ]
  http/tests/inspector/network/har/har-page.html [ Timeout ]
  http/tests/inspector/network/loadResource-insecure-resource.html [ Timeout ]
  http/tests/inspector/network/local-resource-override-basic.html [ Timeout ]
  http/tests/inspector/network/local-resource-override-main-resource.html [ Timeout ]
  http/tests/inspector/network/local-resource-override-script-tag.html [ Timeout ]
  http/tests/inspector/network/resource-initiatorNode.html [ Timeout ]
  http/tests/inspector/network/resource-metrics.html [ Timeout ]
  http/tests/inspector/network/resource-mime-type.html [ Timeout ]
  http/tests/inspector/network/resource-request-headers.html [ Timeout ]
  http/tests/inspector/network/resource-response-inspector-override.html [ Timeout ]
  http/tests/inspector/network/resource-response-service-worker.html [ Timeout ]
  http/tests/inspector/network/resource-response-source-disk-cache.html [ Timeout ]
  http/tests/inspector/network/resource-response-source-memory-cache-revalidate-expired-only.html [ Timeout ]
  http/tests/inspector/network/resource-response-source-memory-cache.html [ Timeout ]
  http/tests/inspector/network/resource-response-source-network.html [ Timeout ]
  http/tests/inspector/network/resource-sizes-disk-cache.html [ Timeout ]
  http/tests/inspector/network/resource-sizes-memory-cache.html [ Timeout ]
  http/tests/inspector/network/resource-sizes-network.html [ Timeout ]
  http/tests/inspector/network/resource-timing.html [ Timeout ]
  http/tests/inspector/network/set-resource-caching-disabled-disk-cache.html [ Timeout ]
  http/tests/inspector/network/set-resource-caching-disabled-memory-cache.html [ Timeout ]
  http/tests/inspector/network/source-map-loads.html [ Timeout ]
  http/tests/inspector/network/x-frame-options.html [ Timeout ]
  http/tests/inspector/network/xhr-request-data-encoded-correctly.html [ Timeout ]
  http/tests/inspector/network/xhr-response-body.html [ Timeout ]
  http/tests/inspector/target/pause-on-inline-debugger-statement.html [ Timeout ]
  http/tests/inspector/target/provisional-load-cancels-previous-load.html [ Timeout ]
  http/tests/inspector/target/target-events-for-provisional-page.html [ Timeout ]
  http/tests/inspector/worker/blob-script-with-cross-domain-imported-scripts.html [ Timeout ]
  http/tests/resourceLoadStatistics/clear-in-memory-and-persistent-store-one-hour.html [ Timeout ]
  inspector/animation/effectChanged.html [ Timeout ]
  inspector/audit/basic-async.html [ Timeout ]
  inspector/canvas/console-record-2d.html [ Timeout ]
  inspector/controller/runtime-controller-import.html [ Timeout ]
  inspector/cpu-profiler/threads.html [ Timeout ]
Comment 6 Diego Pino 2020-04-25 17:20:00 PDT
The tests are only failing in GTK bot because the WPE bot was not running WebInspector tests.
Comment 7 Diego Pino 2020-04-26 06:25:29 PDT
It's unclear the tests are failing due to a regression after
Comment 8 Diego Pino 2020-04-26 06:32:11 PDT
It's unclear the tests are failing due to a regression after r260672.

I'm able to run the inspector tests (inspector/, http/test/inspector) in r260723 without errors. However, the tests are still failing in the GTK test bot https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Tests%29/builds/13492.

I will need more time to investigate what's the reason why the tests are failing in the GTK test bot only.
Comment 9 Diego Pino 2020-05-06 22:34:35 PDT
Reverted r260713 for reason:

Change not needed after r260844

Committed r261267: <https://trac.webkit.org/changeset/261267>
Comment 10 Diego Pino 2020-05-08 02:14:05 PDT
Reverting this patch was the right thing to do after r260844. There's nothing else to do.